Skip to content

Commit affcbe4

Browse files
committed
fix: Don't mention shell tool call
1 parent 00c5539 commit affcbe4

File tree

3 files changed

+9
-30
lines changed

3 files changed

+9
-30
lines changed

AGENTS.md

Lines changed: 5 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ The codebase uses a custom actor model ([internal/actor/actor.go](internal/actor
4343

4444
Key actors in the system:
4545
- **Orchestrator Actor**: Manages LLM interactions and tool execution
46-
- **Tool Actors**: Execute individual tools (read_file, create_file, write_file_diff, shell, etc.)
46+
- **Tool Actors**: Execute individual tools (read_file, create_file, write_file_diff, etc.)
4747
- **Session Actor**: Manages conversation state and file tracking
4848
- **FS Actor**: Handles filesystem operations with caching
4949

@@ -91,7 +91,7 @@ Sessions track conversation state and enforce safety rules ([internal/session/se
9191

9292
- **FilesRead**: Map of files read in session (required for write operations)
9393
- **FilesModified**: Tracks which files were changed
94-
- **BackgroundJobs**: Manages long-running shell commands
94+
- **BackgroundJobs**: Manages long-running sandbox commands
9595
- **Thread-safe**: All operations use read/write locks
9696

9797
#### Tool Registry System
@@ -108,28 +108,11 @@ Available tools:
108108
- **read_file_summarized**: AI-powered summarization of large files
109109
- **create_file**: Create new files
110110
- **write_file_diff**: Update existing files with unified diffs (headers + `@@` hunks by default; GPT models get a simplified parser that tolerates missing hunks)
111-
- **shell**: Execute shell commands (supports background jobs with `&`)
112111
- **go_sandbox**: Execute Go code in sandboxed environment
113112
- **parallel_tools**: Execute several registered tools concurrently and merge responses
114113
- **todo**: Manage todo items
115114
- **status**: Check status of background jobs
116115

117-
### Critical Safety Rules
118-
119-
1. **Read-Before-Write**: Files must be read before modification ([internal/tools/write_file_diff.go](internal/tools/write_file_diff.go#L73) or the simplified parser variant in [internal/tools/write_file_simple_diff.go](internal/tools/write_file_simple_diff.go#L60))
120-
- Session tracks which files were read via `TrackFileRead()`
121-
- Write operations check `WasFileRead()` before allowing modifications
122-
- New files can be written without reading
123-
124-
2. **Line Limits**: Maximum 2000 lines per read operation ([internal/tools/read_file.go](internal/tools/read_file.go:96-104))
125-
- Files exceeding limit are automatically truncated with notification
126-
- Use `from_line` and `to_line` parameters to read specific ranges
127-
128-
3. **Timeouts**:
129-
- Sandbox execution: 30s default, 600s max
130-
131-
4. **Sandbox Shell Helper**: When writing Go sandbox programs, call `Shell` with a command slice (e.g., `Shell([]string{"ls", "-la"}, "")`). The earlier `Shell("ls -la")` form is deprecated and will be rejected.
132-
133116
### Configuration
134117

135118
Configuration files stored in `~/.config/scriptschnell/`:
@@ -144,9 +127,9 @@ Configuration files stored in `~/.config/scriptschnell/`:
144127

145128
### Provider System
146129

147-
Multi-provider support via langchaingo ([internal/provider/provider.go](internal/provider/provider.go)):
130+
Multi-provider support
148131

149-
- Supports OpenAI, Anthropic, and other langchaingo-compatible providers
132+
- Supports OpenAI, Anthropic and other
150133
- Provider manager handles API key storage and model selection
151134
- Model search uses Aho-Corasick algorithm for efficient matching
152135

@@ -167,7 +150,6 @@ When modifying the codebase:
167150

168151
3. **Changing LLM integration**:
169152
- Update `internal/llm/client.go` interface if needed
170-
- Modify langchaingo wrapper in `internal/llm/langchain.go`
171153
- Test with multiple providers (OpenAI, Anthropic)
172154

173155
4. **Actor system changes**:
@@ -185,7 +167,7 @@ scriptschnell/
185167
│ ├── cli/ # CLI mode
186168
│ ├── config/ # Configuration management
187169
│ ├── fs/ # Filesystem abstraction (CachedFS, MockFS)
188-
│ ├── llm/ # LLM client interface + langchaingo wrapper
170+
│ ├── llm/ # LLM client interface
189171
│ ├── provider/ # Provider management (API keys, models)
190172
│ ├── session/ # Session state management
191173
│ ├── tools/ # LLM tools (read_file, create_file, write_file_diff, shell, etc.)
@@ -195,7 +177,6 @@ scriptschnell/
195177
## Dependencies
196178

197179
- **bubbletea**: TUI framework
198-
- **langchaingo**: LLM integration (OpenAI, Anthropic, etc.)
199180
- **fsnotify**: Filesystem watcher for cache invalidation
200181
- **ahocorasick**: Efficient model name search
201182

CLAUDE.md

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -259,9 +259,9 @@ componentLogger := logger.Global().WithPrefix("mycomponent")
259259

260260
### Provider System
261261

262-
Multi-provider support via langchaingo ([internal/provider/provider.go](internal/provider/provider.go)):
262+
Multi-provider support
263263

264-
- Supports OpenAI, Anthropic, and other langchaingo-compatible providers
264+
- Supports OpenAI, Anthropic and other
265265
- Provider manager handles API key storage and model selection
266266
- Model search uses Aho-Corasick algorithm for efficient matching
267267

@@ -282,7 +282,6 @@ When modifying the codebase:
282282

283283
3. **Changing LLM integration**:
284284
- Update `internal/llm/client.go` interface if needed
285-
- Modify langchaingo wrapper in `internal/llm/langchain.go`
286285
- Test with multiple providers (OpenAI, Anthropic)
287286

288287
4. **Actor system changes**:
@@ -300,7 +299,7 @@ scriptschnell/
300299
│ ├── cli/ # CLI mode
301300
│ ├── config/ # Configuration management
302301
│ ├── fs/ # Filesystem abstraction (CachedFS, MockFS)
303-
│ ├── llm/ # LLM client interface + langchaingo wrapper
302+
│ ├── llm/ # LLM client interface
304303
│ ├── provider/ # Provider management (API keys, models)
305304
│ ├── session/ # Session state management
306305
│ ├── tools/ # LLM tools (read_file, create_file, write_file_diff, shell, etc.)
@@ -310,7 +309,6 @@ scriptschnell/
310309
## Dependencies
311310

312311
- **bubbletea**: TUI framework
313-
- **langchaingo**: LLM integration (OpenAI, Anthropic, etc.)
314312
- **wasmer-go**: WebAssembly runtime with WASI support and custom host function hooks for sandboxed code execution
315313
- **fsnotify**: Filesystem watcher for cache invalidation
316314
- **ahocorasick**: Efficient model name search

internal/llm/system_prompt_template.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ You are an interactive CLI agent specializing in software engineering tasks. You
8282
2. Answer the question
8383
- **Fix failing Tests or Build**
8484
1. Run tests or build (investigate what tooling is required only if necessary, otherwise the context may be sufficient)
85-
- Use the go_sandbox tool to run tests or build with shell commands
85+
- Use the go_sandbox tool to run tests (e.g. with the Shell method)
8686
- Try to extract only errors from the output with the tool_summarize and/or searching it in the go_sandbox tool
8787
2. Gather context about errors (with codebase investigator)
8888
3. If necessary, think about what are root causes for the errors and how to fix them

0 commit comments

Comments
 (0)