Skip to content

Commit 81ce73e

Browse files
Resolve conflict: Merge with main
2 parents fed73fa + bb1cac0 commit 81ce73e

File tree

7 files changed

+576
-578
lines changed

7 files changed

+576
-578
lines changed

internal/test_cases/blocking_client_group_test_case.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ func (t *BlockingClientGroupTestCase) SendBlockingCommands() error {
5555
}
5656

5757
func (t *BlockingClientGroupTestCase) AssertResponses(logger *logger.Logger) error {
58-
for _, clientWithExpectedResponse := range t.clientsWithExpectedResponses {
58+
for i := len(t.clientsWithExpectedResponses) - 1; i >= 0; i-- {
59+
clientWithExpectedResponse := t.clientsWithExpectedResponses[i]
5960
clientLogger := clientWithExpectedResponse.Client.GetLogger()
6061
if clientWithExpectedResponse.Assertion == nil {
6162
testCase := NoResponseTestCase{}

internal/test_helpers/fixtures/geospatial/pass

Lines changed: 143 additions & 143 deletions
Large diffs are not rendered by default.

internal/test_helpers/fixtures/lists/blpop_wrong_client

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,22 +4,20 @@ Debug = true
44
[tester::#EC3] $ ./spawn_redis_server.sh
55
[your_program] Logs from your program will appear here!
66
[your_program] Redis server listening on 0.0.0.0:6379
7-
[tester::#EC3] [client-1] Connected (port 63777 -> port 6379)
8-
[tester::#EC3] [client-2] Connected (port 63778 -> port 6379)
9-
[tester::#EC3] [client-3] Connected (port 63779 -> port 6379)
7+
[tester::#EC3] [client-1] Connected (port 59889 -> port 6379)
8+
[tester::#EC3] [client-2] Connected (port 59890 -> port 6379)
9+
[tester::#EC3] [client-3] Connected (port 59891 -> port 6379)
10+
[tester::#EC3] [client-1] $ redis-cli BLPOP pear 0
11+
[tester::#EC3] [client-1] Sent bytes: "*3\r\n$5\r\nBLPOP\r\n$4\r\npear\r\n$1\r\n0\r\n"
1012
[tester::#EC3] [client-2] $ redis-cli BLPOP pear 0
1113
[tester::#EC3] [client-2] Sent bytes: "*3\r\n$5\r\nBLPOP\r\n$4\r\npear\r\n$1\r\n0\r\n"
12-
[tester::#EC3] [client-3] $ redis-cli BLPOP pear 0
13-
[tester::#EC3] [client-3] Sent bytes: "*3\r\n$5\r\nBLPOP\r\n$4\r\npear\r\n$1\r\n0\r\n"
14-
[tester::#EC3] [client-1] $ redis-cli RPUSH pear orange
15-
[tester::#EC3] [client-1] Sent bytes: "*3\r\n$5\r\nRPUSH\r\n$4\r\npear\r\n$6\r\norange\r\n"
16-
[tester::#EC3] [client-1] Received bytes: ":1\r\n"
17-
[tester::#EC3] [client-1] Received RESP integer: 1
18-
[tester::#EC3] [client-1] ✔︎ Received 1
19-
[tester::#EC3] [client-2] Expecting response of BLPOP command
20-
[tester::#EC3] Received: "" (no content received)
21-
[tester::#EC3]  ^ error
22-
[tester::#EC3] Error: Expected start of a new RESP2 value (either +, -, :, $ or *)
14+
[tester::#EC3] [client-3] $ redis-cli RPUSH pear orange
15+
[tester::#EC3] [client-3] Sent bytes: "*3\r\n$5\r\nRPUSH\r\n$4\r\npear\r\n$6\r\norange\r\n"
16+
[tester::#EC3] [client-3] Received bytes: ":1\r\n"
17+
[tester::#EC3] [client-3] Received RESP integer: 1
18+
[tester::#EC3] [client-3] ✔︎ Received 1
19+
[tester::#EC3] [client-2] Expecting no response
20+
[tester::#EC3] client-2 received unexpected response: "*2\r\n$4\r\npear\r\n$6\r\norange\r\n"
2321
[tester::#EC3] Test failed
2422
[tester::#EC3] Terminating program
2523
[tester::#EC3] Program terminated successfully

internal/test_helpers/fixtures/lists/pass

Lines changed: 126 additions & 126 deletions
Large diffs are not rendered by default.

internal/test_helpers/fixtures/pubsub/pass

Lines changed: 140 additions & 140 deletions
Large diffs are not rendered by default.

internal/test_helpers/fixtures/zset/pass

Lines changed: 150 additions & 150 deletions
Large diffs are not rendered by default.

internal/test_list_blpop_no_timeout.go

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,15 @@ func testListBlpopNoTimeout(stageHarness *test_case_harness.TestCaseHarness) err
2424
defer c.Close()
2525
}
2626

27-
sendingClient := clients[0]
28-
2927
listKey := testerutils_random.RandomWord()
3028
pushValue := testerutils_random.RandomWord()
3129

3230
blPopResponseAssertion := resp_assertions.NewOrderedStringArrayAssertion([]string{listKey, pushValue})
3331

3432
blockingClientGroupTestCase := test_cases.BlockingClientGroupTestCase{}
3533
blockingClientGroupTestCase.
36-
AddClientWithExpectedResponse(clients[1], "BLPOP", []string{listKey, "0"}, blPopResponseAssertion).
37-
AddClientWithNoExpectedResponse(clients[2], "BLPOP", []string{listKey, "0"})
34+
AddClientWithExpectedResponse(clients[0], "BLPOP", []string{listKey, "0"}, blPopResponseAssertion).
35+
AddClientWithNoExpectedResponse(clients[1], "BLPOP", []string{listKey, "0"})
3836

3937
// We only send commands here, not expecting responses yet
4038
if err := blockingClientGroupTestCase.SendBlockingCommands(); err != nil {
@@ -47,6 +45,7 @@ func testListBlpopNoTimeout(stageHarness *test_case_harness.TestCaseHarness) err
4745
Assertion: resp_assertions.NewIntegerAssertion(1),
4846
}
4947

48+
sendingClient := clients[2]
5049
if err := rpushTestCase.Run(sendingClient, logger); err != nil {
5150
return err
5251
}

0 commit comments

Comments
 (0)