Merge pull request #200 from codecrafters-io/andy/feat

Add NewSimpleStringAssertion for PING/PONG

Author: andy1li

internal/resp_assertions/simple_string_assertion.go

@@ -0,0 +1,27 @@
+package resp_assertions
+
+import (
+	"fmt"
+
+	resp_value "github.com/codecrafters-io/redis-tester/internal/resp/value"
+)
+
+type SimpleStringAssertion struct {
+	ExpectedValue string
+}
+
+func NewSimpleStringAssertion(expectedValue string) RESPAssertion {
+	return SimpleStringAssertion{ExpectedValue: expectedValue}
+}
+
+func (a SimpleStringAssertion) Run(value resp_value.Value) error {
+	if value.Type != resp_value.SIMPLE_STRING {
+		return fmt.Errorf("Expected simple string, got %s", value.Type)
+	}
+
+	if value.String() != a.ExpectedValue {
+		return fmt.Errorf("Expected %q, got %q", a.ExpectedValue, value.String())
+	}
+
+	return nil
+}

internal/test_cases/send_replication_handshake_test_case.go

@@ -41,7 +41,7 @@ func (t SendReplicationHandshakeTestCase) RunPingStep(client *instrumented_resp_
 	commandTest := SendCommandTestCase{
 		Command:   "PING",
 		Args:      []string{},
-		Assertion: resp_assertions.NewStringAssertion("PONG"),
+		Assertion: resp_assertions.NewSimpleStringAssertion("PONG"),
 	}
 
 	return commandTest.Run(client, logger)

internal/test_ping_pong.go

@@ -27,7 +27,7 @@ func testPingPongOnce(stageHarness *test_case_harness.TestCaseHarness) error {
 	commandTestCase := test_cases.SendCommandTestCase{
 		Command:   "ping",
 		Args:      []string{},
-		Assertion: resp_assertions.NewStringAssertion("PONG"),
+		Assertion: resp_assertions.NewSimpleStringAssertion("PONG"),
 	}
 
 	if err := commandTestCase.Run(client, logger); err != nil {
@@ -122,7 +122,7 @@ func runPing(logger *logger.Logger, client *instrumented_resp_connection.Instrum
 	commandTestCase := test_cases.SendCommandTestCase{
 		Command:   "ping",
 		Args:      []string{},
-		Assertion: resp_assertions.NewStringAssertion("PONG"),
+		Assertion: resp_assertions.NewSimpleStringAssertion("PONG"),
 	}
 
 	if err := commandTestCase.Run(client, logger); err != nil {

internal/test_pubsub_subscribe4.go

@@ -45,7 +45,7 @@ func testPubSubSubscribe4(stageHarness *test_case_harness.TestCaseHarness) error
 	/* Test against ping from a separate (unsubscribed) client */
 	pingTestCase2 := test_cases.SendCommandTestCase{
 		Command:   "PING",
-		Assertion: resp_assertions.NewStringAssertion("PONG"),
+		Assertion: resp_assertions.NewSimpleStringAssertion("PONG"),
 	}
 	return pingTestCase2.Run(clients[1], logger)
 }