Merge pull request #220 from codecrafters-io/redis-geospatial-updates

Updates after testing

Author: UdeshyaDhungana

Makefile

@@ -96,6 +96,7 @@ test_all_with_redis:
 	make test_list_with_redis || true
 	make test_pubsub_with_redis || true
 	make test_zset_with_redis || true
+	make test_geospatial_with_redis || true
 
 setup:
 	echo "Setting up redis-tester prerequisites for Linux"

go.mod

@@ -5,7 +5,7 @@ go 1.24
 toolchain go1.24.2
 
 require (
-	github.com/codecrafters-io/tester-utils v0.4.8-0.20250822020829-f572c78c46fc
+	github.com/codecrafters-io/tester-utils v0.4.8
 	github.com/hdt3213/rdb v1.2.0
 	github.com/stretchr/testify v1.10.0
 	github.com/tidwall/pretty v1.2.1
@@ -19,7 +19,7 @@ require (
 	github.com/mattn/go-isatty v0.0.20 // indirect
 	github.com/mitchellh/go-testing-interface v1.14.1 // indirect
 	github.com/pmezard/go-difflib v1.0.0 // indirect
-	golang.org/x/sys v0.33.0 // indirect
+	golang.org/x/sys v0.35.0 // indirect
 	gopkg.in/yaml.v2 v2.4.0 // indirect
 )
 

go.sum

@@ -6,8 +6,8 @@ github.com/chenzhuoyu/base64x v0.0.0-20211019084208-fb5309c8db06/go.mod h1:DH46F
 github.com/chenzhuoyu/base64x v0.0.0-20221115062448-fe3a3abad311/go.mod h1:b583jCggY9gE99b6G5LEC39OIiVsWj+R97kbl5odCEk=
 github.com/cloudwego/base64x v0.1.4/go.mod h1:0zlkT4Wn5C6NdauXdJRhSKRlJvmclQ1hhJgA0rcu/8w=
 github.com/cloudwego/iasm v0.2.0/go.mod h1:8rXZaNYT2n95jn+zTI1sDr+IgcD2GVs0nlbbQPiEFhY=
-github.com/codecrafters-io/tester-utils v0.4.8-0.20250822020829-f572c78c46fc h1:IeVtegwreCuVUvx7THUROaEUEyNkM7pGMjvYBK6ImLU=
-github.com/codecrafters-io/tester-utils v0.4.8-0.20250822020829-f572c78c46fc/go.mod h1:Fyrv4IebzjWtvKfpYf8ooYDoOtjYe2qx8bV7KAJpX+w=
+github.com/codecrafters-io/tester-utils v0.4.8 h1:+37SwsQ93ni+Tkz1/tNoDuqYbhvOS0nsbdeJrzRumpc=
+github.com/codecrafters-io/tester-utils v0.4.8/go.mod h1:Fyrv4IebzjWtvKfpYf8ooYDoOtjYe2qx8bV7KAJpX+w=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
 github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c=
 github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=
@@ -43,8 +43,8 @@ golang.org/x/arch v0.9.0/go.mod h1:FEVrYAQjsQXMVJ1nsMoVVXPZg6p2JE2mx8psSWTDQys=
 golang.org/x/sys v0.5.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.6.0/go.mod h1:oPkhp1MJrh7nUepCBck5+mAzfO9JrbApNNgaTdGDITg=
 golang.org/x/sys v0.24.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
-golang.org/x/sys v0.33.0 h1:q3i8TbbEz+JRD9ywIRlyRAQbM0qF7hu24q3teo2hbuw=
-golang.org/x/sys v0.33.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
+golang.org/x/sys v0.35.0 h1:vz1N37gP5bs89s7He8XuIYXpyY0+QlsKmzipCbUtyxI=
+golang.org/x/sys v0.35.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
 gopkg.in/yaml.v2 v2.4.0 h1:D8xgwECY7CYvx+Y2n4sBz93Jn9JRvxdiyyo8CTfuKaY=

internal/resp/value/value.go

@@ -138,6 +138,10 @@ func (v Value) ToSerializable() interface{} {
 	switch v.Type {
 	case BULK_STRING:
 		return v.String()
+	case NIL:
+		return "$-1\r\n"
+	case NIL_ARRAY:
+		return "*-1\r\n"
 	case INTEGER:
 		return v.Integer()
 	case ARRAY:

internal/test_cases/geodist_test_case.go

@@ -20,7 +20,7 @@ func (t *GeoDistTestCase) Run(client *instrumented_resp_connection.InstrumentedR
 	geodistTestCase := SendCommandTestCase{
 		Command:   "GEODIST",
 		Args:      []string{t.Key, t.Location1.Name, t.Location2.Name},
-		Assertion: resp_assertions.NewFloatingPointBulkStringAssertion(distance, 10e-4),
+		Assertion: resp_assertions.NewFloatingPointBulkStringAssertion(distance, 1e-4),
 	}
 
 	return geodistTestCase.Run(client, logger)

internal/test_cases/geopos_test_case.go

@@ -68,7 +68,7 @@ func (t *GeoPosTestCase) Run(client *instrumented_resp_connection.InstrumentedRe
 
 	// Assertions for existing locations
 	for _, location := range t.Locations {
-		tolerance := 10e-6
+		tolerance := 1e-6
 
 		if t.ShouldSkipCoordinatesVerfication {
 			tolerance = math.Inf(1)