Merge pull request #169 from codecrafters-io/fix-confusing-stage-1-messagse

Don't mention long-running process in earlier stages

Author: rohitpaulk

internal/rdb_file_creator_test.go

@@ -1,7 +1,6 @@
 package internal
 
 import (
-	"fmt"
 	"io"
 	"os"
 	"path/filepath"
@@ -26,7 +25,6 @@ func TestRDBFileCreator(t *testing.T) {
 
 	fh, _ := os.Open(filepath.Join(RDBFileCreator.Dir, RDBFileCreator.Filename))
 	defer fh.Close()
-	fmt.Println("File content:")
 	data, err := io.ReadAll(fh)
 	if err != nil {
 		t.Fatalf("CodeCrafters Tester Error: %s", err)
@@ -37,5 +35,4 @@ func TestRDBFileCreator(t *testing.T) {
 	version := versionData[5:9]
 	assert.Equal(t, "REDIS", magicString)
 	assert.Equal(t, "0011", version)
-	t.Logf("Version: %s", version)
 }

internal/test_cases/bind_test_case.go

@@ -30,7 +30,12 @@ func (t BindTestCase) Run(executable *redis_executable.RedisExecutable, logger *
 
 		if err != nil {
 			if executable.HasExited() {
-				return fmt.Errorf("Looks like your program has terminated. A redis server is expected to be a long-running process.")
+				// We don't need to mention that the user's program exited or is expected to be a long-running process as
+				// this could be confusing in early stages where the user is expected to only handle a single request from
+				// a single client.
+				//
+				// Let's just exit early and not retry if this happens.
+				return fmt.Errorf("Failed to connect to port %d.", t.Port)
 			}
 
 			// Don't print errors in the first second

internal/test_helpers/fixtures/bind/failure

@@ -2,5 +2,5 @@
 [stage-1] $ ./spawn_redis_server.sh
 [stage-1] Connecting to port 6379...
 [your_program] hey, not going to bind!
-[stage-1] Looks like your program has terminated. A redis server is expected to be a long-running process.
+[stage-1] Failed to connect to port 6379.
 [stage-1] Test failed (try setting 'debug: true' in your codecrafters.yml to see more details)