Merge pull request #2725 from codecrafters-io/update-draft-view-permission

rohitpaulk · web-flow · commit 3b8f2d5f05a6 · 2025-03-07T16:50:51.000-08:00
refactor: clarify variable name for draft visibility
diff --git a/app/controllers/concepts.ts b/app/controllers/concepts.ts
@@ -33,9 +33,9 @@ export default class ConceptsController extends Controller {
 
   get visibleConcepts(): ConceptModel[] {
     return this.model.concepts.filter((concept) => {
-      const canViewDraft = this.currentUser?.isStaff || concept.author === this.currentUser;
+      const canViewIfDraft = this.currentUser?.isStaff || concept.author === this.currentUser;
 
-      return concept.statusIsPublished || (concept.statusIsDraft && canViewDraft);
+      return concept.statusIsPublished || (concept.statusIsDraft && canViewIfDraft);
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -33,9 +33,9 @@ export default class ConceptsController extends Controller {`
`33`	`33`
`34`	`34`	`get visibleConcepts(): ConceptModel[] {`
`35`	`35`	`return this.model.concepts.filter((concept) => {`
`36`		`- const canViewDraft = this.currentUser?.isStaff \|\| concept.author === this.currentUser;`
	`36`	`+ const canViewIfDraft = this.currentUser?.isStaff \|\| concept.author === this.currentUser;`
`37`	`37`
`38`		`- return concept.statusIsPublished \|\| (concept.statusIsDraft && canViewDraft);`
	`38`	`+ return concept.statusIsPublished \|\| (concept.statusIsDraft && canViewIfDraft);`
`39`	`39`	`});`
`40`	`40`	`}`
`41`	`41`