feat(pay): update login flow and button text for clarity

Refactor the login process to redirect users to the catalog page after 
initiating login, enhancing user experience. Update button text to 
reflect the action of trying a free project for unauthenticated users, 
and adjust tooltips accordingly. Modify acceptance tests to ensure 
correct behavior and messaging throughout the pay page.

Author: rohitpaulk

app/components/pay-page/pricing-card.hbs

@@ -72,10 +72,14 @@
         {{svg-jar "github" class="fill-current w-4 transform transition-all mr-2"}}
       {{/unless}}
 
-      Start membership →
+      {{#if this.authenticator.isAuthenticated}}
+        Start membership →
+      {{else}}
+        Try a free project →
+      {{/if}}
 
       {{#unless this.authenticator.isAuthenticated}}
-        <EmberTooltip @text="Login via GitHub to start a membership." />
+        <EmberTooltip @text="Login via GitHub to try a free project." />
       {{/unless}}
     </button>
 

app/controllers/pay.ts

@@ -58,7 +58,8 @@ export default class PayController extends Controller {
       this.configureCheckoutSessionModalIsOpen = true;
       this.selectedPricingFrequency = pricingFrequency;
     } else {
-      this.authenticator.initiateLogin();
+      // The CTA is "Try a free project ->", so doesn't make sense to redirect to /pay again
+      this.authenticator.initiateLoginAndRedirectTo('/catalog');
     }
   }
 

tests/acceptance/pay-test.js

@@ -25,19 +25,16 @@ module('Acceptance | pay-test', function (hooks) {
     await payPage.pricingCards[0].startPaymentButton.hover();
 
     assertTooltipContent(assert, {
-      contentString: 'Login via GitHub to start a membership.',
+      contentString: 'Login via GitHub to try a free project.',
     });
   });
 
-  test('user can view the page through the upgrade button', async function (assert) {
+  test('user can view the page through the pricing link', async function (assert) {
     testScenario(this.server);
 
     await catalogPage.visit();
 
-    assert.ok(catalogPage.header.upgradeButton.isVisible, 'Upgrade button is visible');
-
-    await catalogPage.header.upgradeButton.click();
-
+    await catalogPage.header.clickOnHeaderLink('Pricing');
     assert.strictEqual(currentURL(), '/pay');
   });
 
@@ -49,7 +46,7 @@ module('Acceptance | pay-test', function (hooks) {
 
     assert.strictEqual(
       windowMock.location.href,
-      `${windowMock.location.origin}/login?next=http%3A%2F%2Flocalhost%3A${window.location.port}%2Fpay`,
+      `${windowMock.location.origin}/login?next=http%3A%2F%2Flocalhost%3A${window.location.port}%2Fcatalog`,
       'should redirect to login URL',
     );
   });