Merge pull request #2701 from codecrafters-io/fix-pre-rendering-tracks

Fix fetching languages when pre-rendering tracks

Author: VasylMarchuk

app/adapters/application.ts

@@ -2,12 +2,14 @@ import JSONAPIAdapter from '@ember-data/adapter/json-api';
 import { inject as service } from '@ember/service';
 import config from 'codecrafters-frontend/config/environment';
 import { posthog } from 'posthog-js';
+import type FastbootService from 'ember-cli-fastboot/services/fastboot';
 import type SessionTokenStorageService from 'codecrafters-frontend/services/session-token-storage';
 import type VersionTrackerService from 'codecrafters-frontend/services/version-tracker';
 
 export default class ApplicationAdapter extends JSONAPIAdapter {
   namespace = 'api/v1';
 
+  @service declare fastboot: FastbootService;
   @service declare sessionTokenStorage: SessionTokenStorageService;
   @service declare versionTracker: VersionTrackerService;
 
@@ -34,4 +36,16 @@ export default class ApplicationAdapter extends JSONAPIAdapter {
   get host() {
     return config.x.backendUrl;
   }
+
+  shouldBackgroundReloadAll() {
+    // Don't use background reloading under FastBoot, otherwise it will run
+    // after the app is destroyed and crash the build in a very funny way.
+    return !this.fastboot.isFastBoot;
+  }
+
+  shouldBackgroundReloadRecord() {
+    // Don't use background reloading under FastBoot, otherwise it will run
+    // after the app is destroyed and crash the build in a very funny way.
+    return !this.fastboot.isFastBoot;
+  }
 }

app/routes/track.ts

@@ -5,7 +5,6 @@ import config from 'codecrafters-frontend/config/environment';
 import scrollToTop from 'codecrafters-frontend/utils/scroll-to-top';
 import type AuthenticatorService from 'codecrafters-frontend/services/authenticator';
 import type CourseModel from 'codecrafters-frontend/models/course';
-import type FastbootService from 'ember-cli-fastboot/services/fastboot';
 import type LanguageModel from 'codecrafters-frontend/models/language';
 import type MetaDataService from 'codecrafters-frontend/services/meta-data';
 import type Store from '@ember-data/store';
@@ -20,7 +19,6 @@ export default class TrackRoute extends BaseRoute {
   allowsAnonymousAccess = true;
 
   @service declare authenticator: AuthenticatorService;
-  @service declare fastboot: FastbootService;
   @service declare metaData: MetaDataService;
   @service declare store: Store;
 
@@ -49,12 +47,9 @@ export default class TrackRoute extends BaseRoute {
       include: 'extensions,stages,language-configurations.language',
     })) as unknown as CourseModel[];
 
-    // TODO: Investigate why running this in FastBoot causes a build error
-    if (!this.fastboot.isFastBoot) {
-      (await this.store.findAll('language', {
-        include: 'primer-concept-group,primer-concept-group.author,primer-concept-group.concepts,primer-concept-group.concepts.author',
-      })) as unknown as LanguageModel[];
-    }
+    (await this.store.findAll('language', {
+      include: 'primer-concept-group,primer-concept-group.author,primer-concept-group.concepts,primer-concept-group.concepts.author',
+    })) as unknown as LanguageModel[];
 
     const language = this.store.peekAll('language').find((language) => language.slug === params.track_slug)!;
 

app/serializers/application.js

@@ -6,19 +6,21 @@ export const SERIALIZER_SHOEBOX_IDENTIFIER = 'application-serializer-data';
 export default class ApplicationSerializer extends JSONAPISerializer {
   @service fastboot;
 
-  normalize(...args) {
+  normalize(typeClass, hash) {
     if (this.fastboot.isFastBoot) {
-      // Get the record's original resorce hash that was passed in arguments
-      const [, resourceHash] = args;
+      // Throw human-readable error if FastBoot service is destroyed instead of "document is undefined"
+      if (this.fastboot.isDestroyed) {
+        throw new Error(`Attempted to write a record into shoebox using a destroyed FastBoot service: ${hash.type}`);
+      }
 
       // Retrieve existing records from shoebox cache
       const shoeboxRecords = this.fastboot.shoebox.retrieve(SERIALIZER_SHOEBOX_IDENTIFIER) || [];
 
       // Update shoebox cache, adding the new record
-      this.fastboot.shoebox.put(SERIALIZER_SHOEBOX_IDENTIFIER, [...shoeboxRecords, resourceHash]);
+      this.fastboot.shoebox.put(SERIALIZER_SHOEBOX_IDENTIFIER, [...shoeboxRecords, hash]);
     }
 
-    return super.normalize(...args);
+    return super.normalize(typeClass, hash);
   }
 
   normalizeQueryRecordResponse(store, primaryModelClass, payload, id, requestType) {