Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move reports across commits #31

Open
aj-codecov opened this issue Jul 14, 2023 · 2 comments
Open

Move reports across commits #31

aj-codecov opened this issue Jul 14, 2023 · 2 comments
Assignees

Comments

@aj-codecov
Copy link
Collaborator

aj-codecov commented Jul 14, 2023

https://codecov.canny.io/admin/feedback/customer-requests/p/ability-to-move-reports-across-commits

A XXXXXXXX request

They want to be able to take the coverage of one commit and move it to another - implementation could be CLI based at first, that's likely the easiest path forward

@aj-codecov aj-codecov converted this from a draft issue Jul 14, 2023
@rohan-at-sentry
Copy link
Collaborator

rohan-at-sentry commented Aug 19, 2024

I'd support tackling this in Q4 2024 (we're already underway with Q3). This will help in the following scenario

Our scenario is that we can't upload to Codecov on post-merge since we don't want to run another post-merge CI/CD pipeline. The commit landing on the main branch already went through our mergequeue system and has a perfectly valid coverage report.
As of today, the flow looks like this, with a lot of extra steps in both our CI & postmerge:
CI runs tests, generates coverage report, uploads to Codecov,
CI stores report internally,
PR lands, kicks off a job
Job fetches report from storage, reclones Git repo, reuploads to Codecov with new commit SHA
The ideal flow would be:
CI runs tests, generates coverage report, uploads to Codecov,

if I analyze closely, this pain should be something all larger customers currently feel (explained by most commits not having a "base report" to pick from , and not just isolated to 1 customer. A merge commit not running CI (because everything until then is tested) is totally reasonable, and we should consider expanding our processing capabilities to account for this workflow.

@rohan-at-sentry rohan-at-sentry self-assigned this Aug 19, 2024
@rohan-at-sentry
Copy link
Collaborator

Quick workaround (?) (courtesy @drazisil-codecov ) - modify existing worker logic to not only look for a single parent, esp if that parent doesn't have a coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Solution Discovery
Development

No branches or pull requests

2 participants