refactor: mejoramos los type para la carpeta modelo usando buenas practicas para tener una aplicación mas mantenible

Author: jhonattan

src/models/cart.model.ts

@@ -1,49 +1,44 @@
-import { type Product } from "./product.model";
+import { type Product } from "./product.model";
 
 import type { CategoryVariant } from "./category.model";
 import type { Cart as PrismaCart } from "@/../generated/prisma/client";
+import type { Nullable } from "./utils.model";
 
 export type Cart = PrismaCart;
 
+type productInfo = Pick<
+  Product,
+  "id" | "title" | "imgSrc" | "alt" | "price" | "isOnSale"
+>;
+
 export type CartItem = {
   id: number;
   cartId: number;
   productId: number;
-  categoryVariantId: number | null;
+  categoryVariantId: Nullable<number>;
   quantity: number;
-  finalPrice: number; // ← number, no Decimal
+  finalPrice: number;
   createdAt: Date;
   updatedAt: Date;
-  // Campos adicionales transformados
-  product: Pick<
-    Product,
-    "id" | "title" | "imgSrc" | "alt" | "price" | "isOnSale"
-  >;
-  categoryVariant?: CategoryVariant | null;
+  product: productInfo;
+  categoryVariant?: Nullable<CategoryVariant>;
 };
 
 export interface CartItemInput {
   productId: Product["id"];
   quantity: number;
-  categoryVariantId: number | null;
-  variantInfo: string | null;
+  categoryVariantId: Nullable<number>;
+  variantInfo: Nullable<string>;
   title: Product["title"];
   price: Product["price"];
   imgSrc: Product["imgSrc"];
 }
 
-// Tipo para representar un producto simplificado en el carrito
-
-export type CartProductInfo = Pick<
-  Product,
-  "id" | "title" | "imgSrc" | "alt" | "price" | "isOnSale"
->;
-
 // Tipo para representar un item de carrito con su producto
 export type CartItemWithProduct = {
-  product: CartProductInfo;
+  product: productInfo;
   quantity: number;
-  categoryVariantId: number | null;
+  categoryVariantId: Nullable<number>;
   finalPrice: number;
 };
 

src/models/category.model.ts

@@ -1,13 +1,11 @@
 import type { Category as PrismaCategory } from "@/../generated/prisma/client";
+import type { CategoryVariant as PrismaCategoryVariant } from "@/../generated/prisma/client";
 
 export const VALID_SLUGS = ["polos", "stickers", "tazas"] as const;
 
 export type Category = PrismaCategory;
 
-export type CategoryVariant = {
-  id: number;
-  label: string;
-  value: string;
+export type CategoryVariant = Omit<PrismaCategoryVariant, "priceModifier"> & {
   priceModifier: number;
 };
 

src/models/order.model.ts

@@ -2,6 +2,7 @@ import type {
   Order as PrismaOrder,
   OrderItem as PrismaOrderItem,
 } from "@/../generated/prisma/client";
+import type { Nullable } from "./utils.model";
 
 export type OrderDetails = Pick<
   PrismaOrder,
@@ -29,10 +30,10 @@ export type Order = Omit<PrismaOrder, "totalAmount"> & {
 
 export interface OrderItemInput {
   productId: number;
-  categoryVariantId?: number | null;
+  categoryVariantId?: Nullable<number>;
   quantity: number;
   title: string;
-  variantInfo?: string | null; // ← NUEVO
+  variantInfo?: Nullable<string>;
   price: number;
   imgSrc: string;
 }

src/models/utils.model.ts

@@ -0,0 +1,3 @@
+export type Nullable<T> = T | null;
+export type Optional<T> = T | undefined;
+export type Maybe<T> = T | null | undefined;