Generalize ArrayConverter

Author: dvlpp

src/Form/Fields/Formatters/SelectFormatter.php

@@ -3,6 +3,7 @@
 namespace Code16\Sharp\Form\Fields\Formatters;
 
 use Code16\Sharp\Form\Fields\SharpFormField;
+use Code16\Sharp\Utils\Transformers\ArrayConverter;
 
 class SelectFormatter extends SharpFieldFormatter
 {
@@ -16,20 +17,11 @@ function toFront(SharpFormField $field, $value)
         if($field->multiple()) {
             return collect((array)$value)
                 ->map(function($item) use($field) {
+                    $item = ArrayConverter::modelToArray($item);
 
-                    if(is_array($item)) {
-                        return $item[$field->idAttribute()];
-                    }
-
-                    if(is_object($item)) {
-                        if(method_exists($item, "toArray")) {
-                            return $item->toArray()[$field->idAttribute()];
-                        }
-
-                        return ((array)$item)[$field->idAttribute()];
-                    }
-
-                    return $item;
+                    return is_array($item)
+                        ? $item[$field->idAttribute()]
+                        : $item;
                 })
                 ->all();
 

src/Form/Fields/Formatters/TagsFormatter.php

@@ -3,6 +3,7 @@
 namespace Code16\Sharp\Form\Fields\Formatters;
 
 use Code16\Sharp\Form\Fields\SharpFormField;
+use Code16\Sharp\Utils\Transformers\ArrayConverter;
 
 class TagsFormatter extends SharpFieldFormatter
 {
@@ -16,10 +17,11 @@ function toFront(SharpFormField $field, $value)
     {
         return collect((array)$value)
             ->map(function($item) use($field) {
+                $item = ArrayConverter::modelToArray($item);
 
-                if(is_object($item) || is_array($item)) {
+                if(is_array($item)) {
                     return [
-                        "id" => ((array)$item)[$field->idAttribute()],
+                        "id" => $item[$field->idAttribute()],
                     ];
                 }
 

src/Form/Fields/Utils/SharpFormFieldWithOptions.php

@@ -2,6 +2,7 @@
 
 namespace Code16\Sharp\Form\Fields\Utils;
 
+use Code16\Sharp\Utils\Transformers\ArrayConverter;
 use Illuminate\Support\Collection;
 
 trait SharpFormFieldWithOptions
@@ -19,9 +20,9 @@ protected static function formatOptions($options, $idAttribute = "id")
         }
 
         $options = collect($options);
+        $firstOption = ArrayConverter::modelToArray($options->first());
 
-        if((is_array($options->first()) || is_object($options->first()))
-            && isset(((array)$options->first())[$idAttribute])) {
+        if(is_array($firstOption) && isset($firstOption[$idAttribute])) {
             // We assume that we already have ["id", "label"] in this case
             return $options->all();
         }

src/Utils/Transformers/ArrayConverter.php

@@ -0,0 +1,31 @@
+<?php
+
+namespace Code16\Sharp\Utils\Transformers;
+
+class ArrayConverter
+{
+
+    /**
+     * Convert a class or Model into an array.
+     * If $model is not an array or model, simply return it.
+     *
+     * @param array|object|mixed $model
+     * @return array|mixed
+     */
+    public static function modelToArray($model)
+    {
+        if(is_array($model)) {
+            return $model;
+        }
+
+        if(is_object($model)) {
+            if(method_exists($model, "toArray")) {
+                return $model->toArray();
+            }
+
+            return (array)$model;
+        }
+
+        return $model;
+    }
+}

src/Utils/Transformers/WithCustomTransformers.php

@@ -7,7 +7,6 @@
 use Code16\Sharp\Form\SharpForm;
 use Illuminate\Contracts\Pagination\LengthAwarePaginator as LengthAwarePaginatorContract;
 use Illuminate\Pagination\LengthAwarePaginator;
-use stdClass;
 
 /**
  * This trait allows a class to handle a custom transformers array.
@@ -100,7 +99,7 @@ function apply($value, $instance = null, $attribute = null)
      */
     protected function applyTransformers($model, bool $forceFullObject = true)
     {
-        $attributes = is_array($model) ? $model: ($model instanceof stdClass ? (array)$model: $model->toArray());
+        $attributes = ArrayConverter::modelToArray($model);
 
         if($forceFullObject) {
             // Merge model attribute with form fields to be sure we have