Skip to content

Commit 2ddf8ca

Browse files
authored
[ci] Fix check_access again (facebook#32935)
I can see the value being output and set correctly but not sure why it's skipping the 2nd job. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32935). * facebook#32936 * __->__ facebook#32935
1 parent 95ff37f commit 2ddf8ca

File tree

3 files changed

+15
-15
lines changed

3 files changed

+15
-15
lines changed

.github/workflows/compiler_discord_notify.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
check_access:
1414
runs-on: ubuntu-latest
1515
outputs:
16-
is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
16+
is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
1717
steps:
18-
- name: Check access
19-
id: check_access
18+
- name: Check is member or collaborator
19+
id: check_is_member_or_collaborator
2020
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
21-
run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
21+
run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
2222

2323
check_maintainer:
24-
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
24+
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
2525
needs: [check_access]
2626
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
2727
permissions:

.github/workflows/runtime_discord_notify.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,15 +13,15 @@ jobs:
1313
check_access:
1414
runs-on: ubuntu-latest
1515
outputs:
16-
is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
16+
is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
1717
steps:
18-
- name: Check access
19-
id: check_access
18+
- name: Check is member or collaborator
19+
id: check_is_member_or_collaborator
2020
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
21-
run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
21+
run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
2222

2323
check_maintainer:
24-
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
24+
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
2525
needs: [check_access]
2626
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
2727
permissions:

.github/workflows/shared_label_core_team_prs.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ jobs:
1414
check_access:
1515
runs-on: ubuntu-latest
1616
outputs:
17-
is_member_or_collaborator: ${{ steps.check_access.outputs.is_member_or_collaborator }}
17+
is_member_or_collaborator: ${{ steps.check_is_member_or_collaborator.outputs.is_member_or_collaborator }}
1818
steps:
19-
- name: Check access
20-
id: check_access
19+
- name: Check is member or collaborator
20+
id: check_is_member_or_collaborator
2121
if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'COLLABORATOR' }}
22-
run: echo "is_member_or_collaborator='true'" >> "$GITHUB_OUTPUT"
22+
run: echo "is_member_or_collaborator=true" >> "$GITHUB_OUTPUT"
2323

2424
check_maintainer:
25-
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' }}
25+
if: ${{ needs.check_access.outputs.is_member_or_collaborator == 'true' || needs.check_access.outputs.is_member_or_collaborator == true }}
2626
needs: [check_access]
2727
uses: facebook/react/.github/workflows/shared_check_maintainer.yml@main
2828
permissions:

0 commit comments

Comments
 (0)