fix(package): add ./server export for OpenCode-Go plugin compatibility#2988
Open
odedindi wants to merge 1 commit intocode-yeongyu:devfrom
Open
fix(package): add ./server export for OpenCode-Go plugin compatibility#2988odedindi wants to merge 1 commit intocode-yeongyu:devfrom
odedindi wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
OpenCode-Go's resolveExportPath checks exports["./server"] before falling back to the main field. Without this entry, fs.realpathSync resolves the entry path relative to CWD instead of the package directory, triggering a containment security check failure: ERROR path=oh-my-opencode error=Plugin resolved server entry outside plugin directory Fixes code-yeongyu#2966
Contributor
|
All contributors have signed the CLA. Thank you! ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Safe configuration change to package.json exports to fix tool compatibility; no logic changes or impact on existing entry points.
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCode-Go's resolveExportPath checks exports["./server"] before falling back to the main field. Without this entry, fs.realpathSync resolves the entry path relative to CWD instead of the package directory, triggering a containment security check failure:
ERROR path=oh-my-opencode error=Plugin resolved server entry outside plugin directory
Fixes #2966
Summary
Changes
Screenshots
Testing
bun run typecheck bun testRelated Issues
Summary by cubic
Add
exports["./server"]to package.json soOpenCode-Goresolves the server entry correctly and avoids the containment check error. Fixes #2966.Written for commit 28b0a75. Summary will update on new commits.