Merge pull request #3 from code-yeongyu/injectable

`URLChanger` 의 URL 들이 쉽게 변경 가능 하도록 property 로 변경합니다.

Author: code-yeongyu

package.json

@@ -1,6 +1,6 @@
 {
   "name": "trackpurchase",
-  "version": "0.1.6",
+  "version": "0.1.7",
   "main": "src/index.ts",
   "license": "MIT",
   "repository": {
@@ -20,7 +20,10 @@
   ],
   "jest": {
     "preset": "jest-puppeteer",
-    "coveragePathIgnorePatterns": ["dist/", "elementParser.ts"]
+    "coveragePathIgnorePatterns": [
+      "dist/",
+      "elementParser.ts"
+    ]
   },
   "scripts": {
     "test": "jest .",

src/app/naver/pageInteractor.ts

@@ -8,7 +8,7 @@ export default class PageInteractor {
     this.page = page;
   }
 
-  async login(id: string, password: string, delay?: number) {
+  async login(id: string, password: string, delay?: number, loginURL?: string) {
     await Promise.all([
       this.page.waitForSelector("#id"),
       this.page.waitForSelector("#pw"),
@@ -24,7 +24,11 @@ export default class PageInteractor {
       this.page.waitForNavigation({ waitUntil: "networkidle2" }),
     ]);
 
-    if (this.page.url().includes("https://nid.naver.com/nidlogin.login")) {
+    if (
+      this.page
+        .url()
+        .includes(loginURL || "https://nid.naver.com/nidlogin.login")
+    ) {
       throw new Error("Login failed");
     }
   }

src/app/naver/urlChanger.test.ts

@@ -10,9 +10,7 @@ describe("Login", () => {
     await urlChanger.moveToLoginURL();
 
     // then
-    expect(pageSpy).toHaveBeenCalledWith(
-      "https://nid.naver.com/nidlogin.login"
-    );
+    expect(pageSpy).toHaveBeenCalledWith(urlChanger.loginURL);
   });
 });
 
@@ -28,8 +26,6 @@ describe("PaymentHistory", () => {
     await urlChanger.moveToPaymentHistoryURL();
 
     // then
-    expect(pageSpy).toHaveBeenCalledWith(
-      "https://new-m.pay.naver.com/historybenefit/paymenthistory"
-    );
+    expect(pageSpy).toHaveBeenCalledWith(urlChanger.paymentHistoryURL);
   });
 });

src/app/naver/urlChanger.ts

@@ -2,19 +2,20 @@ import puppeteer from "puppeteer";
 
 export default class URLChanger {
   private readonly page: puppeteer.Page;
+  loginURL = "https://nid.naver.com/nidlogin.login";
+  paymentHistoryURL =
+    "https://new-m.pay.naver.com/historybenefit/paymenthistory";
 
   constructor(page: puppeteer.Page) {
     this.page = page;
   }
 
   async moveToLoginURL() {
-    await this.page.goto("https://nid.naver.com/nidlogin.login");
+    await this.page.goto(this.loginURL);
   }
 
   async moveToPaymentHistoryURL() {
-    await this.page.goto(
-      "https://new-m.pay.naver.com/historybenefit/paymenthistory"
-    );
+    await this.page.goto(this.paymentHistoryURL);
     await this.page.waitForSelector("div[class^='paymentHistory_section__']");
   }
 }