Merge pull request #13 from code-yeongyu/remove-legacy

사용하지 않는 메소드들을 삭제합니다.

Author: code-yeongyu

src/app/naver/elementParser.test.ts

@@ -1,18 +1,16 @@
-import Module from "./module";
+import { NaverModule } from "./module";
 import ModuleFactory from "./moduleFactory";
 import URLChanger from "./urlChanger";
 import PageInteractor, { LoginEvent, CaptchaStatus } from "./pageInteractor";
-import ElementParser from "./elementParser";
 import Service from "./service";
 import { NaverScraper } from "./scraper";
 import { NaverParser } from "./parser";
 
 export {
-  Module,
+  NaverModule,
   ModuleFactory,
   URLChanger,
   PageInteractor,
-  ElementParser,
   Service,
   LoginEvent,
   CaptchaStatus,

src/app/naver/elementParser.ts

@@ -1,16 +1,8 @@
-import {
-  URLChanger,
-  PageInteractor,
-  ElementParser,
-  NaverScraper,
-  NaverParser,
-} from ".";
-import { Module as BaseModule } from "../common";
+import { URLChanger, PageInteractor, NaverScraper, NaverParser } from ".";
 
-export default interface Module extends BaseModule {
+export default interface Module {
   readonly urlChanger: URLChanger;
   readonly pageInteractor: PageInteractor;
-  readonly elementParser: ElementParser;
   readonly scraper: NaverScraper;
   readonly parser: NaverParser;
 }

src/app/naver/index.ts

@@ -2,7 +2,6 @@ import puppeteer from "puppeteer";
 import {
   Module,
   URLChanger,
-  ElementParser,
   PageInteractor,
   NaverScraper,
   NaverParser,
@@ -11,15 +10,13 @@ import {
 export default class ModuleFactory {
   static create(page: puppeteer.Page): Module {
     const urlChanger = new URLChanger(page);
-    const elementParser = new ElementParser(page);
-    const pageInteractor = new PageInteractor(page, elementParser);
+    const pageInteractor = new PageInteractor(page);
     const scraper = new NaverScraper();
     const parser = new NaverParser();
 
     return {
       urlChanger,
       pageInteractor,
-      elementParser,
       scraper,
       parser,
     };

src/app/naver/module.ts

@@ -13,14 +13,8 @@ export interface CaptchaStatus {
 }
 
 export default class PageInteractor {
-  private _fullyLoaded = false;
-
-  constructor(
-    private readonly page: puppeteer.Page,
-    private readonly elementParser: ElementParser
-  ) {
+  constructor(private readonly page: puppeteer.Page) {
     this.page = page;
-    this.elementParser = elementParser;
   }
 
   private async clickLoginButton() {

src/app/naver/moduleFactory.ts

@@ -1,31 +1,17 @@
 import URLChanger from "./urlChanger";
 
-describe("Login", () => {
-  it("Should move page to login", async () => {
-    // given
-    const urlChanger = new URLChanger(page);
-    const pageSpy = jest.spyOn(page, "goto");
+describe("URLChanger", () => {
+  describe("moveToLoginURL", () => {
+    it("Should move page to login", async () => {
+      // given
+      const urlChanger = new URLChanger(page);
+      const pageSpy = jest.spyOn(page, "goto");
 
-    // when
-    await urlChanger.moveToLoginURL();
+      // when
+      await urlChanger.moveToLoginURL();
 
-    // then
-    expect(pageSpy).toHaveBeenCalledWith(urlChanger.loginURL);
-  });
-});
-
-describe("PaymentHistory", () => {
-  it("Should move page to payment history", async () => {
-    // given
-    const urlChanger = new URLChanger(page);
-    const pageSpy = jest.spyOn(page, "goto");
-    const waitForSelectorSpy = jest.spyOn(page, "waitForSelector");
-    waitForSelectorSpy.mockImplementation(() => Promise.resolve(null));
-
-    // when
-    await urlChanger.moveToPaymentHistoryURL();
-
-    // then
-    expect(pageSpy).toHaveBeenCalledWith(urlChanger.paymentHistoryURL);
+      // then
+      expect(pageSpy).toHaveBeenCalledWith(urlChanger.loginURL);
+    });
   });
 });

src/app/naver/pageInteractor.test.ts

@@ -1,20 +1,12 @@
 import puppeteer from "puppeteer";
 
 export default class URLChanger {
-  loginURL = "https://nid.naver.com/nidlogin.login";
-  paymentHistoryURL =
-    "https://new-m.pay.naver.com/historybenefit/paymenthistory";
-
   constructor(private readonly page: puppeteer.Page) {
     this.page = page;
   }
 
+  loginURL = "https://nid.naver.com/nidlogin.login";
   async moveToLoginURL() {
     await this.page.goto(this.loginURL);
   }
-
-  async moveToPaymentHistoryURL() {
-    await this.page.goto(this.paymentHistoryURL);
-    await this.page.waitForSelector("div[class^='paymentHistory_section__']");
-  }
 }