Skip to content

Commit 45ba92e

Browse files
committed
docs: clarify readyz stub and /validate bypass; drop no-op objectSelector
readyz is a liveness-equivalent stub, not a dependency probe. /validate only covers hand-rolled Deployment/StatefulSet paths; the CocoonSet main flow creates Pods directly and never hits it. The mutate objectSelector filtered on a label that no producer writes (the key is only ever an annotation), so it was a no-op — pod_mutator already fast-allows non-cocoon pods.
1 parent bef05fb commit 45ba92e

2 files changed

Lines changed: 2 additions & 7 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@ cocoon-webhook hosts three admission endpoints:
99
| Endpoint | Type | Resources | What it does |
1010
|---|---|---|---|
1111
| `POST /mutate` | Mutating | Pod CREATE | Rejects cocoon-tolerated pods that are not owned by a CocoonSet. CocoonSet-owned pods pass through unmutated. |
12-
| `POST /validate` | Validating | Deployment / StatefulSet UPDATE | Rejects scale-down on cocoon-tolerated workloads (agents are stateful VMs — use `CocoonHibernation` to suspend instead). |
12+
| `POST /validate` | Validating | Deployment / StatefulSet UPDATE | Rejects scale-down on cocoon-tolerated workloads. Bypass path for hand-rolled Deployments/StatefulSets carrying the cocoon toleration — the CocoonSet main flow creates Pods directly and does not traverse this endpoint. |
1313
| `POST /validate-cocoonset` | Validating | CocoonSet CREATE / UPDATE | Catches the cross-field business rules the CRD's OpenAPI schema cannot express (image required, toolbox name uniqueness, static-mode prerequisites). |
1414
| `GET /healthz` | Liveness || Always 200 once the binary is running. |
15-
| `GET /readyz` | Readiness || 200 once dependencies needed to serve admission traffic are reachable. |
15+
| `GET /readyz` | Readiness || Always 200 once the binary is running (liveness-equivalent stub; does not probe apiserver reachability). |
1616
| `GET /metrics` | Prometheus || Plain HTTP on `:9090`, separate from the admission TLS port. |
1717

1818
## CocoonSet validation rules

config/webhook/configuration.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,6 @@ webhooks:
1010
sideEffects: None
1111
failurePolicy: Ignore
1212
timeoutSeconds: 5
13-
objectSelector:
14-
matchExpressions:
15-
- key: cocoonset.cocoonstack.io/managed
16-
operator: NotIn
17-
values: ["false"]
1813
rules:
1914
- apiGroups: [""]
2015
apiVersions: ["v1"]

0 commit comments

Comments
 (0)