Skip to content

server,rpc: the RPC heartbeat server incorrectly performs version check on CLI clients #90131

Open
@knz

Description

@knz

We have a cross-version compatibility guarantee between CLI clients and servers, such that it should be possible to use version N-1 of the CLI to access version N servers, and vice-versa.

There is a regression for this since v21.1 it is not any more possible to use e.g. a v21.2 CLI to operate a v22.1 server, or a v22.1 CLI to operate a v22.2 server.

(The problem still exists in v23.1)

For example, cockroach node drain fails with:

ERROR: failed to connect to the node: initial connection heartbeat failed: rpc error: code = Unknown desc = version compatibility check failed on ping request: cluster requires at least version 22.1-74, but peer has version 22.1

Jira issue: CRDB-20604

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-cli-serverCLI commands that pertain to CockroachDB server processesA-kv-serverRelating to the KV-level RPC serverC-bugCode not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.T-kvKV Teambranch-masterFailures and bugs on the master branch.regressionRegression from a release.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions