Skip to content

spanconfig: improve redaction for spanconfig reconciler error #155380

@rafiss

Description

@rafiss

These logs show that we might be over-redacting an error when the spanconfig reconciler fails.

AUTO SPAN CONFIG RECONCILIATION job 1115060038728810497: stepping through state failed with unexpected error: reconciliation unsuccessful, failing job
(1) forced error mark
  | ‹×›
  | github.com/cockroachdb/errors/withstack/*withstack.withStack::
Wraps: (2) attached stack trace
  -- stack trace:
  | github.com/cockroachdb/cockroach/pkg/spanconfig/spanconfigjob.(*resumer).Resume
  | 	pkg/spanconfig/spanconfigjob/job.go:196
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine.func2
  | 	pkg/jobs/registry.go:1720
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).stepThroughStateMachine
  | 	pkg/jobs/registry.go:1721
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).runJob
  | 	pkg/jobs/adopt.go:410
  | github.com/cockroachdb/cockroach/pkg/jobs.(*Registry).resumeJob.func1
  | 	pkg/jobs/adopt.go:263
  | github.com/cockroachdb/cockroach/pkg/util/stop.(*Stopper).RunAsyncTaskEx.func2
  | 	pkg/util/stop/stopper.go:500
  | runtime.goexit
  | 	src/runtime/asm_amd64.s:1700
Wraps: (3) reconciliation unsuccessful, failing job
Error types: (1) *markers.withMark (2) *withstack.withStack (3) *errutil.leafError

We should check to see if the forced error mark ‹×› includes any useful information that we should not be redacting. Do we log the actual error in any of the surrounding logs?

Jira issue: CRDB-55414

Epic CRDB-55074

Metadata

Metadata

Assignees

Labels

C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-sql-foundationsSQL Foundations Team (formerly SQL Schema + SQL Sessions)branch-release-25.4Used to mark GA and release blockers and technical advisories for 25.4target-release-25.4.0target-release-26.1.0

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions