Skip to content

cli: better guardrail against max-offset misconfiguration #128959

Open
@tbg

Description

@tbg

Is your feature request related to a problem? Please describe.

In a recent issue1, a user started a single node using --max-offset=5000ms
(combined with --disable-max-offset-check) to evaluate performance of an
insert workload. However, CRDB really isn't functional with a --max-offset of
that magnitude; max offsets must not exceed be a small fraction of the liveness
heartbeat interval.

We could've saved a good amount of time diagnosing this had it been impossible
to start a server with this value.

Describe the solution you'd like

Refuse to start with --max-offset outside an admissible range.

Describe alternatives you've considered

Additional context

See #127969.

Jira issue: CRDB-41304

Epic CRDB-43580

Footnotes

  1. https://github.com/cockroachdb/cockroach/issues/127969#issuecomment-2288629720

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-cli-flagsPertains to CLI flag handling common to all CLI commandsA-cli-serverCLI commands that pertain to CockroachDB server processesC-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)O-supportWould prevent or help troubleshoot a customer escalation - bugs, missing observability/tooling, docsP-3Issues/test failures with no fix SLAT-kvKV Teambranch-masterFailures and bugs on the master branch.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions