Skip to content

Commit d99f8d5

Browse files
author
healthy-pod
committed
teamcity-trigger: ensure that race tag is only passed once
By running under `-race`, the go command defines the `race` build tag for us [1]. Previously, we defined it under `TAGS` to let the issue poster know that this is a failure under `race` and indicate that in the issue. At the time, defining the tag twice didn't cause issues but after #109773, it led to build failures [2]. To reproduce locally: ``` bazel test -s --config=race pkg/util/ctxgroup:all --test_env=GOTRACEBACK=all --define gotags=bazel,gss,race ``` As a follow-up, we should find another way to let the issue poster know that a failure was running under `race`. [1] https://go.dev/doc/articles/race_detector#Excluding_Tests [2] #109994 (comment) Epic: none Release note: None
1 parent b5836a5 commit d99f8d5

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

pkg/cmd/teamcity-trigger/main.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ func runTC(queueBuild func(string, map[string]string)) {
194194
opts["env.EXTRA_BAZEL_FLAGS"] = fmt.Sprintf("%s --@io_bazel_rules_go//go/config:race --test_env=GORACE=halt_on_error=1", extraBazelFlags)
195195
opts["env.STRESSFLAGS"] = fmt.Sprintf("-maxruns %d -maxtime %s -maxfails %d -p %d",
196196
maxRuns, maxTime, maxFails, noParallelism)
197-
opts["env.TAGS"] = "race"
198197
queueBuildThenWait(buildID, opts)
199198
delete(opts, "env.TAGS")
200199
}

0 commit comments

Comments
 (0)