loqrecovery: TODO

Epic: none
Release note: none

Author: pav-kv

pkg/kv/kvserver/loqrecovery/apply.go

@@ -317,6 +317,8 @@ func applyReplicaUpdate(
 
 	hs.LeadEpoch = 0
 
+	// TODO(sep-raft-log): when raft and state machine engines are separated, this
+	// update must be written to the raft engine.
 	if err := sl.SetHardState(ctx, readWriter, hs); err != nil {
 		return PrepareReplicaReport{}, errors.Wrap(err, "setting HardState")
 	}

pkg/kv/kvserver/loqrecovery/collect.go

@@ -192,6 +192,9 @@ func visitStoreReplicas(
 		if err != nil {
 			return err
 		}
+		// TODO(pav-kv): the LoQ recovery flow uses only the applied index, and the
+		// HardState.Commit loaded here is unused. Consider removing. Make sure this
+		// doesn't break compatibility for ReplicaInfo unmarshalling.
 		hstate, err := rsl.LoadHardState(ctx, raft)
 		if err != nil {
 			return err