concurrency: disable kv.lock_table.unreplicated_lock_reliability.split.enabled

stevendanna · stevendanna · commit 5f0e1bfaff91 · 2025-10-15T00:05:50.000+01:00
In cockroachdb#155318, we discovered that the RHS replica's lock table may already have concurrently running transactions holding locks. As a result, adding these locks may put the lock table in an unexpected state. Informs cockroachdb#155318 Release note (bug fix): Disable a feature (kv.lock_table.unreplicated_lock_reliability.split.enabled) that could lead to a node crash.
diff --git a/pkg/kv/kvserver/concurrency/concurrency_manager.go b/pkg/kv/kvserver/concurrency/concurrency_manager.go
@@ -123,7 +123,7 @@ var UnreplicatedLockReliabilitySplit = settings.RegisterBoolSetting(
 	settings.SystemOnly,
 	"kv.lock_table.unreplicated_lock_reliability.split.enabled",
 	"whether the replica should attempt to keep unreplicated locks during range splits",
-	metamorphic.ConstantWithTestBool("kv.lock_table.unreplicated_lock_reliability.split.enabled", true),
+	false,
 )
 
 // UnreplicatedLockReliabilityLeaseTransfer controls whether the replica will attempt

Original file line number	Diff line number	Diff line change
`@@ -123,7 +123,7 @@ var UnreplicatedLockReliabilitySplit = settings.RegisterBoolSetting(`
`123`	`123`	`settings.SystemOnly,`
`124`	`124`	`"kv.lock_table.unreplicated_lock_reliability.split.enabled",`
`125`	`125`	`"whether the replica should attempt to keep unreplicated locks during range splits",`
`126`		`- metamorphic.ConstantWithTestBool("kv.lock_table.unreplicated_lock_reliability.split.enabled", true),`
	`126`	`+ false,`
`127`	`127`	`)`
`128`	`128`
`129`	`129`	`// UnreplicatedLockReliabilityLeaseTransfer controls whether the replica will attempt`