Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution is incorrectly configured as a uriorcurie #72

Open
RobNicholsGDS opened this issue Dec 5, 2023 · 3 comments
Open

distribution is incorrectly configured as a uriorcurie #72

RobNicholsGDS opened this issue Dec 5, 2023 · 3 comments
Assignees

Comments

@RobNicholsGDS
Copy link
Contributor

Describe the bug
When validating a distribution element, the system is only excepting a string as valid input

** The error **
The definition at https://github.com/co-cddo/ukgov-metadata-exchange-model/blob/main/src/model/uk_cross_government_metadata_exchange_model.yaml#L317 is incorrect.

In the section:

  distribution:
    slot_uri: dcat:distribution
    description: An available distribution of the dataset.
    recommended: true
    multivalued: true
    range: uriorcurie

The range should be distribution and not uriorcurie.

@RobNicholsGDS
Copy link
Contributor Author

RobNicholsGDS commented Dec 6, 2023

@AlasdairGray Could you clarify that this is a bug please.

@AlasdairGray
Copy link
Contributor

The modelling is not as tight as we would like it to be. Ideally, we would want to restrict the range to an array of objects that are nested Distribution descriptions or identifiers (URIs or CURIEs) of Distribution descriptions.

By putting in uriorcurie I was capturing the latter case but not the former. The assumption being that Distributions would have their own identity rather than being anonymous resources.

@cyberdudeuk
Copy link
Contributor

@RobNicholsGDS can this be closed now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants