-
Notifications
You must be signed in to change notification settings - Fork 584
Description
This repo currently has a workflow enabled that adds the comment "Wait, please do not proceed with this yet." when a PR with the "hold" label is added.
- https://github.com/cncf/glossary/blob/main/.github/workflows/auto-comment.yml
- https://github.com/cncf/glossary/blob/main/.github/auto-comment-config.yaml
However, when I added the "hold" label to my PR (#3619), "github-actions" (a bot) added 15 duplicate "Wait, please do not proceed with this yet."
To find out why, I looked at https://github.com/cncf/glossary/actions/workflows/auto-comment.yml. When I added the 'hold' label, I also removed the 'lang/xx' labels that were incorrectly attached at the same time. This caused the workflow to be executed separately for each 'lang/xx' label removal event.
This behavior could be prevented by slightly modifying the workflow execution conditions in https://github.com/cncf/glossary/blob/main/.github/workflows/auto-comment.yml.
If anyone would like to take on this task, please comment on this issue to express your interest and open a pull request targeting the main branch.
I encourage anyone interested to contribute.