From f67a4de79ef6435f7cebc3f56a74fb074e53edf6 Mon Sep 17 00:00:00 2001 From: Brian Clark Date: Fri, 19 Jul 2024 13:41:30 -0400 Subject: [PATCH 1/4] TEST Build from this branch --- .github/workflows/build-and-deploy.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-and-deploy.yaml b/.github/workflows/build-and-deploy.yaml index e7cd22c..ee62f5f 100644 --- a/.github/workflows/build-and-deploy.yaml +++ b/.github/workflows/build-and-deploy.yaml @@ -8,7 +8,8 @@ jobs: if: > github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging' || - github.ref == 'refs/heads/development' + github.ref == 'refs/heads/development' || + github.ref == 'refs/heads/update-sentry-config' strategy: matrix: From 2fa2a35b007b57db4a6039b5a1a050a3c2e06a2f Mon Sep 17 00:00:00 2001 From: Brian Clark Date: Fri, 19 Jul 2024 13:41:48 -0400 Subject: [PATCH 2/4] Don't declare as strings --- src/signal_documentation/settings.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/signal_documentation/settings.py b/src/signal_documentation/settings.py index e190577..70baacd 100644 --- a/src/signal_documentation/settings.py +++ b/src/signal_documentation/settings.py @@ -34,9 +34,9 @@ integrations=[DjangoIntegration(), RedisIntegration(max_data_size=0)], traces_sample_rate=float(os.environ.get('SENTRY_TRACES_SAMPLE_RATE', 1.0)), profiles_sample_rate=float(os.environ.get('SENTRY_PROFILES_SAMPLE_RATE', 1.0)), - environment=str(os.environ.get('SENTRY_ENVIRONMENT', 'development')), - debug=str(os.environ.get('SENTRY_DEBUG', 'True')), - attach_stacktrace=str(os.environ.get('SENTRY_ATTACH_STACKTRACE', 'True')) + environment=(os.environ.get('SENTRY_ENVIRONMENT', 'development')), + debug=(os.environ.get('SENTRY_DEBUG', 'True')), + attach_stacktrace=(os.environ.get('SENTRY_ATTACH_STACKTRACE', 'True')) ) From 3e2ee729a70897cd752692605edf6d1a4fb7a251 Mon Sep 17 00:00:00 2001 From: Brian Clark Date: Fri, 19 Jul 2024 13:53:52 -0400 Subject: [PATCH 3/4] Refactor to mimic config in delphi-epidata --- src/signal_documentation/settings.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/signal_documentation/settings.py b/src/signal_documentation/settings.py index 70baacd..c6f5268 100644 --- a/src/signal_documentation/settings.py +++ b/src/signal_documentation/settings.py @@ -30,13 +30,13 @@ SENTRY_DSN = os.environ.get('SENTRY_DSN') if SENTRY_DSN: sentry_sdk.init( - dsn=SENTRY_DSN, - integrations=[DjangoIntegration(), RedisIntegration(max_data_size=0)], - traces_sample_rate=float(os.environ.get('SENTRY_TRACES_SAMPLE_RATE', 1.0)), - profiles_sample_rate=float(os.environ.get('SENTRY_PROFILES_SAMPLE_RATE', 1.0)), - environment=(os.environ.get('SENTRY_ENVIRONMENT', 'development')), - debug=(os.environ.get('SENTRY_DEBUG', 'True')), - attach_stacktrace=(os.environ.get('SENTRY_ATTACH_STACKTRACE', 'True')) + dsn = SENTRY_DSN, + integrations = [DjangoIntegration(), RedisIntegration(max_data_size=0)], + traces_sample_rate = float(os.environ.get('SENTRY_TRACES_SAMPLE_RATE', 1.0)), + profiles_sample_rate = float(os.environ.get('SENTRY_PROFILES_SAMPLE_RATE', 1.0)), + environment = (os.environ.get('SENTRY_ENVIRONMENT', 'development')), + attach_stacktrace = os.environ.get('SENTRY_ATTACH_STACKTRACE', 'False').lower() in ('true', '1', 't'), + debug = os.environ.get('SENTRY_DEBUG', 'False').lower() in ('true', '1', 't') ) From 1e5581c4457e7bb1703c0cba4dbaac637838f9b2 Mon Sep 17 00:00:00 2001 From: Brian Clark Date: Fri, 19 Jul 2024 14:04:48 -0400 Subject: [PATCH 4/4] Remove test branch build --- .github/workflows/build-and-deploy.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build-and-deploy.yaml b/.github/workflows/build-and-deploy.yaml index ee62f5f..e7cd22c 100644 --- a/.github/workflows/build-and-deploy.yaml +++ b/.github/workflows/build-and-deploy.yaml @@ -8,8 +8,7 @@ jobs: if: > github.ref == 'refs/heads/main' || github.ref == 'refs/heads/staging' || - github.ref == 'refs/heads/development' || - github.ref == 'refs/heads/update-sentry-config' + github.ref == 'refs/heads/development' strategy: matrix: