Skip to content

Commit 4c2b552

Browse files
authored
Merge pull request #137 from cmu-delphi/OKRS24-214-Update-SourceSubdivision-model
Okrs24 214 update source subdivision model
2 parents f0d8ff3 + cd5118d commit 4c2b552

File tree

5 files changed

+25
-4
lines changed

5 files changed

+25
-4
lines changed

src/datasources/admin.py

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ class SourceSubdivisionAdmin(ImportExportModelAdmin):
1717
resource_classes: list[type[SourceSubdivisionResource]] = [SourceSubdivisionResource]
1818

1919

20-
data_source_search_fields_type = tuple[Literal['name'], Literal['source_subdivision__db_source'], Literal['source_subdivision__name'], Literal['description']]
21-
22-
2320
@admin.register(DataSource)
2421
class DataSourceAdmin(ImportExportModelAdmin):
2522
"""
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Generated by Django 5.0.3 on 2024-06-05 10:09
2+
3+
from django.db import migrations, models
4+
5+
6+
class Migration(migrations.Migration):
7+
8+
dependencies = [
9+
('datasources', '0004_alter_datasource_options_and_more'),
10+
]
11+
12+
operations = [
13+
migrations.AddField(
14+
model_name='sourcesubdivision',
15+
name='external_name',
16+
field=models.CharField(help_text='External Name', max_length=128, null=True),
17+
),
18+
]

src/datasources/models.py

+5
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ class SourceSubdivision(TimeStampedModel):
1717
max_length=128,
1818
unique=True
1919
)
20+
external_name: models.CharField = models.CharField(
21+
help_text=_('External Name'),
22+
max_length=128,
23+
null=True,
24+
)
2025
description: models.TextField = models.TextField(
2126
help_text=_('Source description'),
2227
max_length=1000,

src/datasources/resources.py

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
class SourceSubdivisionResource(resources.ModelResource):
1313
name = Field(attribute='name', column_name='Source Subdivision')
1414
display_name = Field(attribute='display_name', column_name='Source Subdivision')
15+
external_name = Field(attribute='external_name', column_name='External Name')
1516
description = Field(attribute='description', column_name='Description')
1617
db_source = Field(attribute='db_source', column_name='DB Source')
1718
data_source = Field(

src/templates/signals/signals.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ <h2 class="accordion-header">
316316
{% endif %}
317317
</td>
318318
<td class="clickable-table-cell" onClick="location.href='{% url 'signal' pk=signal.id %}';">
319-
{{ signal.source.data_source }}
319+
{{ signal.source.external_name }}
320320
</td>
321321
<td class="clickable-table-cell" onClick="location.href='{% url 'signal' pk=signal.id %}';">
322322
{{ signal.description}}

0 commit comments

Comments
 (0)