Skip to content

Commit 325d4a7

Browse files
committed
🛠️ models.py -> Updated field types and help texts for models
🛠️ models.py -> Updated field types and help texts for models 🛠️ models.py -> Updated field types and help texts for models 🛠️ models.py -> Updated field types and help texts for models
1 parent 08b094c commit 325d4a7

File tree

3 files changed

+51
-54
lines changed

3 files changed

+51
-54
lines changed

src/base/models.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ class DescriptedFilterField(models.Model):
1515
"""
1616
A model representing a filter field that is descripted.
1717
"""
18-
filter = models.ForeignKey(
18+
filter: models.ForeignKey = models.ForeignKey(
1919
'DescriptedFilter',
2020
on_delete=models.CASCADE,
2121
related_name='filter_fields'
2222
)
23-
filter_field = models.CharField(help_text=_('Filter field'), max_length=256)
24-
description = models.TextField(help_text=_('Filter field description'), blank=True, null=True)
23+
filter_field: models.CharField = models.CharField(help_text=_('Filter field'), max_length=256)
24+
description: models.TextField = models.TextField(help_text=_('Filter field description'), blank=True, null=True)
2525

2626
class Meta:
2727
unique_together = ('filter', 'filter_field')
@@ -38,7 +38,7 @@ class DescriptedFilter(models.Model):
3838
"""
3939
A model representing a filter wich fields are descripted.
4040
"""
41-
filter_name = models.CharField(max_length=256, unique=True, choices=FILTERS_LIST)
41+
filter_name: models.CharField = models.CharField(max_length=256, unique=True, choices=FILTERS_LIST)
4242

4343
def __str__(self) -> str:
4444
"""
@@ -90,7 +90,7 @@ class Link(TimeStampedModel):
9090
"""
9191
A model representing a Link.
9292
"""
93-
link_type = models.CharField(
93+
link_type: models.CharField = models.CharField(
9494
help_text=_('Link type'),
9595
choices=LinkTypeChoices.choices,
9696
max_length=128

src/datasources/models.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,32 +7,32 @@ class SourceSubdivision(TimeStampedModel):
77
"""
88
A model representing a source subdivision.
99
"""
10-
name = models.CharField(
10+
name: models.CharField = models.CharField(
1111
help_text=_('Name'),
1212
max_length=128,
1313
unique=True
1414
)
15-
display_name = models.CharField(
15+
display_name: models.CharField = models.CharField(
1616
help_text=_('Display Name'),
1717
max_length=128,
1818
unique=True
1919
)
20-
description = models.TextField(
20+
description: models.TextField = models.TextField(
2121
help_text=_('Source description'),
2222
max_length=1000,
2323
null=True,
2424
blank=True
2525
)
26-
db_source = models.CharField(
26+
db_source: models.CharField = models.CharField(
2727
help_text=_('DB Source'),
2828
max_length=128,
2929
)
30-
links = models.ManyToManyField(
30+
links: models.ManyToManyField = models.ManyToManyField(
3131
'base.Link',
3232
help_text=_('Source Subdivision links'),
3333
related_name="source_subdivisions"
3434
)
35-
data_source = models.ForeignKey(
35+
data_source: models.ForeignKey = models.ForeignKey(
3636
'datasources.DataSource',
3737
related_name='source_subdivisions',
3838
help_text=_('Source Subdivision'),
@@ -49,35 +49,35 @@ def __str__(self) -> str:
4949
:return: The name of the source subdivision as a string.
5050
:rtype: str
5151
"""
52-
return self.name
52+
return str(self.name)
5353

5454

5555
class DataSource(TimeStampedModel):
5656
"""
5757
A model representing a data source.
5858
"""
5959

60-
name = models.CharField(
60+
name: models.CharField = models.CharField(
6161
help_text=_('Name'),
6262
max_length=128,
6363
unique=True
6464
)
65-
display_name = models.CharField(
65+
display_name: models.CharField = models.CharField(
6666
help_text=_('Display Name'),
6767
max_length=128,
6868
unique=True
6969
)
70-
description = models.TextField(
70+
description: models.TextField = models.TextField(
7171
help_text=_('Source description'),
7272
max_length=1000,
7373
null=True,
7474
blank=True
7575
)
76-
source_license = models.CharField(
76+
source_license: models.CharField = models.CharField(
7777
help_text=_('License'),
7878
max_length=128
7979
)
80-
links = models.ManyToManyField(
80+
links: models.ManyToManyField = models.ManyToManyField(
8181
'base.Link',
8282
help_text=_('DataSource links'),
8383
related_name="data_sources"
@@ -93,4 +93,4 @@ def __str__(self) -> str:
9393
:return: The name of the data source as a string.
9494
:rtype: str
9595
"""
96-
return self.name
96+
return str(self.name)

src/signals/models.py

Lines changed: 33 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ class SignalCategory(TimeStampedModel):
5353
"""
5454
A model representing a signal category.
5555
"""
56-
name = models.CharField(
56+
name: models.CharField = models.CharField(
5757
help_text=_('Name'),
5858
max_length=128,
5959
unique=True
@@ -70,37 +70,34 @@ def __str__(self) -> str:
7070
:return: The name of the signal category as a string.
7171
:rtype: str
7272
"""
73-
return self.name
73+
return str(self.name)
7474

7575

7676
class SignalType(TimeStampedModel):
7777
"""
7878
A model representing a signal type.
7979
"""
80-
name = models.CharField(
80+
name: models.CharField = models.CharField(
8181
help_text=_('Name'),
8282
max_length=128,
8383
unique=True
8484
)
8585

86-
class Meta:
87-
ordering: list[str] = ["name"]
88-
8986
def __str__(self) -> str:
9087
"""
9188
Returns the name of the signal type as a string.
9289
9390
:return: The name of the signal type as a string.
9491
:rtype: str
9592
"""
96-
return self.name
93+
return str(self.name)
9794

9895

9996
class Pathogen(TimeStampedModel):
10097
"""
10198
A model representing a pathogen.
10299
"""
103-
name = models.CharField(
100+
name: models.CharField = models.CharField(
104101
help_text=_('Name'),
105102
max_length=128,
106103
unique=True
@@ -113,14 +110,14 @@ def __str__(self) -> str:
113110
:return: The name of the pathogen as a string.
114111
:rtype: str
115112
"""
116-
return self.name
113+
return str(self.name)
117114

118115

119116
class Geography(TimeStampedModel):
120117
"""
121118
A model representing a available geography.
122119
"""
123-
name = models.CharField(
120+
name: models.CharField = models.CharField(
124121
help_text=_('Name'),
125122
max_length=128,
126123
unique=True
@@ -137,128 +134,128 @@ def __str__(self) -> str:
137134
:return: The name of the available geography as a string.
138135
:rtype: str
139136
"""
140-
return self.name
137+
return str(self.name)
141138

142139

143140
class Signal(TimeStampedModel):
144141
"""
145142
A model representing a signal.
146143
"""
147-
name = models.CharField(
144+
name: models.CharField = models.CharField(
148145
help_text=_('Name'),
149146
max_length=128,
150147
)
151-
display_name = models.CharField(
148+
display_name: models.CharField = models.CharField(
152149
help_text=_('Display Name'),
153150
max_length=128,
154151
)
155-
base = models.ForeignKey(
152+
base: models.ForeignKey = models.ForeignKey(
156153
'signals.Signal',
157154
related_name='base_for',
158155
help_text=_('Signal base'),
159156
on_delete=models.SET_NULL,
160157
null=True,
161158
blank=True
162159
)
163-
pathogen = models.ManyToManyField(
160+
pathogen: models.ManyToManyField = models.ManyToManyField(
164161
'signals.Pathogen',
165162
related_name='signals',
166163
help_text=_('Pathogen/Disease Area'),
167164
)
168-
signal_type = models.ManyToManyField(
165+
signal_type: models.ManyToManyField = models.ManyToManyField(
169166
'signals.SignalType',
170167
related_name='signals',
171168
help_text=_('Signal Type')
172169
)
173-
active = models.BooleanField(
170+
active: models.BooleanField = models.BooleanField(
174171
help_text=_('Active'),
175172
default=False
176173
)
177-
short_description = models.TextField(
174+
short_description: models.TextField = models.TextField(
178175
help_text=_('Short Description'),
179176
max_length=500,
180177
null=True,
181178
blank=True
182179
)
183-
description = models.TextField(
180+
description: models.TextField = models.TextField(
184181
help_text=_('Description'),
185182
max_length=1000,
186183
null=True,
187184
blank=True
188185
)
189-
format_type = models.CharField(
186+
format_type: models.CharField = models.CharField(
190187
help_text=_('Format'),
191188
max_length=128,
192189
choices=FormatChoices.choices
193190
)
194-
time_type = models.CharField(
191+
time_type: models.CharField = models.CharField(
195192
help_text=_('Time type'),
196193
max_length=128,
197194
choices=TimeTypeChoices.choices
198195
)
199-
time_label = models.CharField(
196+
time_label: models.CharField = models.CharField(
200197
help_text=_('Time label'),
201198
max_length=128,
202199
choices=TimeLabelChoices.choices
203200
)
204-
category = models.ForeignKey(
201+
category: models.ForeignKey = models.ForeignKey(
205202
'signals.SignalCategory',
206203
related_name='signals',
207204
help_text=_('Signal Category'),
208205
on_delete=models.SET_NULL,
209206
null=True
210207
)
211-
links = models.ManyToManyField(
208+
links: models.ManyToManyField = models.ManyToManyField(
212209
'base.Link',
213210
help_text=_('Signal links'),
214211
related_name="signals"
215212
)
216-
available_geography = models.ManyToManyField(
213+
available_geography: models.ManyToManyField = models.ManyToManyField(
217214
'signals.Geography',
218215
help_text=_('Available geography')
219216
)
220-
is_smoothed = models.BooleanField(
217+
is_smoothed: models.BooleanField = models.BooleanField(
221218
help_text=_('Is Smoothed'),
222219
default=False
223220
)
224-
is_weighted = models.BooleanField(
221+
is_weighted: models.BooleanField = models.BooleanField(
225222
help_text=_('Is Weighted'),
226223
default=False
227224
)
228-
is_cumulative = models.BooleanField(
225+
is_cumulative: models.BooleanField = models.BooleanField(
229226
help_text=_('Is Cumulative'),
230227
default=False
231228
)
232-
has_stderr = models.BooleanField(
229+
has_stderr: models.BooleanField = models.BooleanField(
233230
help_text=_('Has StdErr'),
234231
default=False
235232
)
236-
has_sample_size = models.BooleanField(
233+
has_sample_size: models.BooleanField = models.BooleanField(
237234
help_text=_('Has Sample Size'),
238235
default=False
239236
)
240-
high_values_are = models.CharField(
237+
high_values_are: models.CharField = models.CharField(
241238
help_text=_('High values are'),
242239
max_length=128,
243240
choices=HighValuesAreChoices.choices
244241
)
245-
source = models.ForeignKey(
242+
source: models.ForeignKey = models.ForeignKey(
246243
'datasources.SourceSubdivision',
247244
related_name='signals',
248245
help_text=_('Source Subdivision'),
249246
on_delete=models.PROTECT,
250247
)
251-
last_updated = models.DateField(
248+
last_updated: models.DateField = models.DateField(
252249
help_text=_('Last Updated'),
253250
null=True,
254251
blank=True
255252
)
256-
from_date = models.DateField(
253+
from_date: models.DateField = models.DateField(
257254
help_text=_('From Date'),
258255
null=True,
259256
blank=True
260257
)
261-
to_date = models.DateField(
258+
to_date: models.DateField = models.DateField(
262259
help_text=_('To Date'),
263260
null=True,
264261
blank=True
@@ -280,7 +277,7 @@ def __str__(self) -> str:
280277
:return: The name of the signal as a string.
281278
:rtype: str
282279
"""
283-
return self.name
280+
return str(self.name)
284281

285282
def clean(self) -> None:
286283
"""

0 commit comments

Comments
 (0)