Skip to content

Commit 3749747

Browse files
committed
Fixed filter names, added epivis custom title
1 parent b5d1d72 commit 3749747

File tree

7 files changed

+20
-29
lines changed

7 files changed

+20
-29
lines changed

src/assets/js/signal_sets.js

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,12 @@ function plotData() {
4747
geographicValues.forEach((geoValue) => {
4848
var geographicValue = (typeof geoValue.id === 'string') ? geoValue.id.toLowerCase() : geoValue.id;
4949
var geographicType = geoValue.geoType;
50+
var epivisCustomTitle;
51+
if (signal["member_short_name"]) {
52+
epivisCustomTitle = `${signal["signal_set_short_name"]}:${signal["member_short_name"]} : ${geoValue.text}`
53+
} else {
54+
epivisCustomTitle = `${signal["signal_set_short_name"]} : ${geoValue.text}`
55+
}
5056
dataSets[`${signal["signal"]}_${geographicValue}`] = {
5157
color: '#'+(Math.random() * 0xFFFFFF << 0).toString(16).padStart(6, '0'),
5258
title: "value",
@@ -56,8 +62,8 @@ function plotData() {
5662
signal: signal["signal"],
5763
time_type: signal["time_type"],
5864
geo_type: geographicType,
59-
geo_value: geographicValue
60-
// custom_title: `${signal["data_source"]}:${signal["signal"]} - ${geoValue.text}`
65+
geo_value: geographicValue,
66+
custom_title: epivisCustomTitle
6167
}
6268
}
6369
})
@@ -99,7 +105,9 @@ function addSelectedSignal(element) {
99105
signal: element.dataset.signal,
100106
time_type: element.dataset.timeType,
101107
signal_set: element.dataset.signalSet,
102-
display_name: element.dataset.signalDisplayname
108+
display_name: element.dataset.signalDisplayname,
109+
signal_set_short_name: element.dataset.signalSetShortName,
110+
member_short_name: element.dataset.memberShortName
103111
});
104112
updateSelectedSignals(element.dataset.datasource, element.dataset.signalDisplayname, element.dataset.signalSet, element.dataset.signal);
105113
} else {
@@ -215,7 +223,7 @@ function format (signalSetId, relatedSignals, signalSetDescription) {
215223
checked = checkedSignalMembers.filter((obj) => obj.data_source == signal.source && obj.signal == signal.name).length;
216224
checked = checked ? "checked" : ""
217225
tableMarkup += '<tr>'+
218-
`<td><input type="checkbox" name="selectedSignal" onclick="addSelectedSignal(this)" data-signal-displayname='${signal.display_name}' data-endpoint="${signal.endpoint}" data-datasource="${signal.source}" data-signal="${signal.name}" data-time-type="${signal.time_type}" data-signal-set="${signal.signal_set_name}" ${checked}></td>`+
226+
`<td><input type="checkbox" name="selectedSignal" onclick="addSelectedSignal(this)" data-signal-displayname='${signal.display_name}' data-endpoint="${signal.endpoint}" data-datasource="${signal.source}" data-signal="${signal.name}" data-time-type="${signal.time_type}" data-signal-set="${signal.signal_set_name}" data-signal-set-short-name="${signal.signal_set_short_name}" data-member-short-name="${signal.member_short_name}" ${checked}></td>`+
219227
`<td>${signal.display_name}</td>`+
220228
`<td>${signal.member_name}</td>`+
221229
`<td>${signal.member_description}</td>`+

src/fixtures/geographic_scopes.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -168,15 +168,5 @@
168168
"name": "Taiwan",
169169
"used_in": "signal_sets"
170170
}
171-
},
172-
{
173-
"model": "signals.geographicscope",
174-
"pk": 66,
175-
"fields": {
176-
"created": "2025-01-16T16:27:36.145Z",
177-
"modified": "2025-01-16T16:27:36.146Z",
178-
"name": "International",
179-
"used_in": "signal_sets"
180-
}
181171
}
182172
]

src/fixtures/pathogens.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -208,15 +208,5 @@
208208
"created": "2023-08-09T19:23:22.597131",
209209
"modified": "2023-08-09T19:23:22.597131"
210210
}
211-
},
212-
{
213-
"model": "signals.Pathogen",
214-
"pk": 22,
215-
"fields": {
216-
"name": "N/A",
217-
"used_in": "signal_sets",
218-
"created": "2023-08-09T19:23:22.597131",
219-
"modified": "2023-08-09T19:23:22.597131"
220-
}
221211
}
222212
]

src/signal_sets/filters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,10 +71,10 @@ class SignalSetFilter(django_filters.FilterSet):
7171
choices=[
7272
("Annually", "Annually"),
7373
("Monthly", "Monthly"),
74-
("Daily", "Daily"),
7574
("Weekly", "Weekly"),
75+
("Daily", "Daily"),
7676
("Hourly", "Hourly"),
77-
("None", "None"),
77+
("Other", "Other"),
7878
],
7979
lookup_expr="icontains",
8080
)

src/signal_sets/forms.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@ class SignalSetFilterForm(forms.ModelForm):
5050
choices=[
5151
("Annually", "Annually"),
5252
("Monthly", "Monthly"),
53-
("Daily", "Daily"),
5453
("Weekly", "Weekly"),
54+
("Daily", "Daily"),
5555
("Hourly", "Hourly"),
56-
("None", "None")
56+
("Other", "Other")
5757
],
5858
widget=forms.CheckboxSelectMultiple(),
5959
)

src/signal_sets/resources.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ def process_datasources(row) -> None:
6767
"""
6868
if row["Original Data Provider"]:
6969
data_source = row["Original Data Provider"]
70-
data_source_obj, _ = DataSource.objects.get_or_create(name=data_source)
70+
data_source_obj, _ = DataSource.objects.get_or_create(name=data_source, defaults={"display_name": data_source.capitalize()})
7171
row["Original Data Provider"] = data_source_obj
7272

7373

@@ -222,6 +222,7 @@ def after_import_row(self, row, row_result, **kwargs):
222222
try:
223223
signal_set_obj = SignalSet.objects.get(id=row_result.object_id)
224224
for pathogen in row["Pathogen(s)/Syndrome(s)"].split(","):
225+
signal_set_obj.pathogens.clear()
225226
pathogen = Pathogen.objects.get(name=pathogen, used_in="signal_sets")
226227
signal_set_obj.pathogens.add(pathogen)
227228
for severity_pyramid_rung in row["Surveillance Categories"].split(","):

src/signal_sets/views.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,11 @@ def get_related_signals(self, queryset):
9696
"id": signal.id,
9797
"display_name": signal.get_display_name,
9898
"member_name": signal.member_name,
99+
"member_short_name": signal.member_short_name,
99100
"name": signal.name,
100101
"signal_set": signal.signal_set.id,
101102
"signal_set_name": signal.signal_set.name,
103+
"signal_set_short_name": signal.signal_set.short_name,
102104
"endpoint": signal.signal_set.endpoint,
103105
"source": signal.source.name,
104106
"time_type": signal.time_type,

0 commit comments

Comments
 (0)