-1 ahead has gotten borked

Author: dsweber2

R/forecasters/data_validation.R

@@ -97,6 +97,16 @@ filter_extraneous <- function(epi_data, filter_source, filter_agg_level) {
   return(epi_data)
 }
 
+#' the minus one ahead causes problems for `quantile_regression` if that data is
+#' actually present, so we should filter it out
+filter_minus_one_ahead <- function(epi_data, ahead) {
+  if (ahead < 0) {
+    dont_include <- attr(epi_data, "metadata")$as_of + ahead
+    epi_data %<>% filter(time_value < dont_include)
+  }
+  epi_data
+}
+
 #' Unwrap an argument if it's a list of length 1
 #'
 #' Many of our arguments to the forecasters come as lists not because we expect

R/forecasters/forecaster_scaled_pop_seasonal.R

@@ -76,6 +76,8 @@ scaled_pop_seasonal <- function(
   epi_data %<>% filter_extraneous(filter_source, filter_agg_level)
   # this is a temp fix until a real fix gets put into epipredict
   epi_data <- clear_lastminute_nas(epi_data, cols = c(outcome, extra_sources))
+  # predicting the -1 ahead when it is present sometimes lead to freezeing
+  epi_data %<>% filter_minus_one_ahead(ahead)
   # this next part is basically unavoidable boilerplate you'll want to copy
   args_input <- list(...)
   # edge case where there is no data or less data than the lags; eventually epipredict will handle this