Skip to content

Check implications of relaxing typeof checks #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brookslogan opened this issue Apr 16, 2025 · 0 comments
Open

Check implications of relaxing typeof checks #662

brookslogan opened this issue Apr 16, 2025 · 0 comments

Comments

@brookslogan
Copy link
Contributor

During #651, some upstream update caused (once again) for some tests to start failing due to integer- vs. double-backed Dates. I'm just eliminating the typeof checks for now, but this may cause some operations to potentially do the wrong thing (next_after?). It would probably be better to vec_cast_common instead of just checking for identical classes.

@brookslogan brookslogan mentioned this issue Apr 16, 2025
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant