-
Notifications
You must be signed in to change notification settings - Fork 8
Consider adding grouped_okay
parameter to is_epi_archive
#649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Alternatively, can we make grouped archives have both epi_archive and grouped_epi_archive like tibbles
|
We/I originally decided against that because it makes grouped archives inherit ungrouped archive implementations, which can be error prone. Unless we & any other archive method implementers make grouped impls / groupedness checks for everything that at least abort, then a user may get an ungrouped op [or even worse, data structure corruption] expecting a grouped one. I ran into this at some point with idea: something sort of similar that might be safer is having
Haven't really thought this through though. (Potentially related: it would be nice to have an interface / abstract class sort of thing for [It also seems more that ungrouped archives could inherit in some sense from grouped ones, since they are like having a single group. But that might look confusing class-wise.] |
Could also put is_epi_archive and is_grouped_epi_archive on the same ref page, so the user can OR the two together if they want to allow both. |
From #644 (comment)
The text was updated successfully, but these errors were encountered: