Skip to content

epix_slide won't grab the latest version #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kenmawer opened this issue Jul 21, 2022 · 2 comments
Closed

epix_slide won't grab the latest version #153

kenmawer opened this issue Jul 21, 2022 · 2 comments
Assignees
@brookslogan
Labels
bug Something isn't working P1 medium priority

Comments

@kenmawer
Copy link
Contributor

Related to #146, but the ref_time_values, which should actually be ref_versions, does not take in the latest version for the slide.
@kenmawer kenmawer added bug Something isn't working P1 medium priority labels Jul 22, 2022
@brookslogan brookslogan mentioned this issue Jul 22, 2022
Closed
7 tasks
@brookslogan
Copy link
Contributor

From call: we should just fix the latest version not being included here, and leave the renaming for a separate discussion. #146 contained some ideas for setting a default.

@brookslogan brookslogan mentioned this issue Aug 19, 2022
Merged
@brookslogan brookslogan self-assigned this Nov 5, 2022
@brookslogan brookslogan mentioned this issue Nov 5, 2022
Closed
brookslogan pushed a commit that referenced this issue Nov 8, 2022
@lcbrooks
Address #153, #124; make clobberable default quiet & msging clearer
7d67021 
For #153:
* Make `epix_slide` use the latest version by making its default an evenly
  spaced sequence guessed from `DT$version`. (Using `guess_period` built on
  `gcd_num`, `gcd2num`.)
* Make `epix_slide` generate error if any `ref_time_values` is outside
  acceptable range; don't silently filter.

For #124:
* Make `epi_slide` generate error if any `ref_time_values` is outside
  acceptable range; don't silently filter.

For clobberable messaging:
* Make default `clobberable_versions_start` be `NA`.
* (Hopefully) improve messaging and docs.

Update docs and NEWS.md.  Fix invalidated tests.
@brookslogan
Copy link
Contributor

Closed by #311.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brookslogan brookslogan

Labels
bug Something isn't working P1 medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brookslogan @kenmawer