Merge pull request #601 from cmu-delphi/lcb/tweak-archive-tol-interface

Tweak archive construction and compactification tolerance interfaces

Author: brookslogan

NAMESPACE

@@ -143,6 +143,7 @@ importFrom(data.table,copy)
 importFrom(data.table,frollapply)
 importFrom(data.table,frollmean)
 importFrom(data.table,frollsum)
+importFrom(data.table,is.data.table)
 importFrom(data.table,key)
 importFrom(data.table,rbindlist)
 importFrom(data.table,set)
@@ -171,7 +172,6 @@ importFrom(dplyr,if_else)
 importFrom(dplyr,is_grouped_df)
 importFrom(dplyr,lag)
 importFrom(dplyr,mutate)
-importFrom(dplyr,near)
 importFrom(dplyr,pick)
 importFrom(dplyr,pull)
 importFrom(dplyr,relocate)
@@ -208,6 +208,7 @@ importFrom(rlang,expr_label)
 importFrom(rlang,f_env)
 importFrom(rlang,f_rhs)
 importFrom(rlang,is_bare_integerish)
+importFrom(rlang,is_bare_numeric)
 importFrom(rlang,is_environment)
 importFrom(rlang,is_formula)
 importFrom(rlang,is_function)
@@ -244,5 +245,5 @@ importFrom(utils,capture.output)
 importFrom(utils,tail)
 importFrom(vctrs,vec_cast)
 importFrom(vctrs,vec_data)
-importFrom(vctrs,vec_detect_missing)
+importFrom(vctrs,vec_duplicate_any)
 importFrom(vctrs,vec_equal)

NEWS.md

@@ -16,6 +16,8 @@ Pre-1.0.0 numbering scheme: 0.x will indicate releases, while 0.x.y will indicat
   you want to use `method = "trendfilter"` you will need to manually install
   this dependency (e.g., with `remotes::install_github("glmgen/trendfilter")`).
 - In `revision_summary()`:
+  - The `should_compactify` argument is now called `compactify`. To migrate,
+    change any calls with `should_compactfiy =` to `compactify =`.
   - Output now uses the name `lag_near_latest` instead of `time_near_latest`. To
     migrate, update references to `time_near_latest` to `lag_near_latest`.
   - `revision_summary(epi_arch)` without specifying the measurement column to
@@ -32,9 +34,18 @@ Pre-1.0.0 numbering scheme: 0.x will indicate releases, while 0.x.y will indicat
     `geo_keys`, `other_keys`, and `time_keys`.
   - The `extra_keys` argument has been deprecated and replaced with
     `other_keys`.
+- The compactification tolerance argument has been renamed to
+  `compactify_abs_tol` or `abs_tol`, depending on the function; now defines a
+  nonstrict tolerances; and defaults to 0 (requiring exact matches in order to
+  compactify). This argument has been added to `as_epi_archive()` and
+  `epix_merge()` and removed (along with all compactification options) from
+  `new_epi_archive()`.
+- `validate_epi_archive()` now follows the validator convention of operating on
+  an "unvalidated" `epi_archive` (from `new_epi_archive`) rather than arguments.
 
 ## Improvements
 - `revision_summary()` now supports all `time_type`s.
+- The compactification tolerance setting now works with integer-type columns.
 
 ## Bug fixes
 
@@ -43,6 +54,8 @@ Pre-1.0.0 numbering scheme: 0.x will indicate releases, while 0.x.y will indicat
 - Fixed `epi_archive` compactification raising an error on certain value column
   classes such as `"distribution"` (#541); it's now easier to form an archive of
   forecasts in that format.
+- Fixed large compactification tolerances potentially removing all versions of
+  some observations in certain cases when activity was flat.
 
 ## Cleanup