refactor(epi_slide_opt): cleaner subresult formation

We can remove some level of call nesting by using existing
new_tibble(vec_recycle_common()) rather than vec_cbind() to incorporate the
group_key.

(While we weren't triggering this behavior, `vec_cbind()` has some ptype rules
that are probably not what we want if `epi_df`s were to be involved, so
hopefully this will also prevent future re-use in a situation where that might
have been the case.)

Author: brookslogan

NAMESPACE

@@ -249,7 +249,6 @@ importFrom(utils,capture.output)
 importFrom(utils,tail)
 importFrom(vctrs,"vec_slice<-")
 importFrom(vctrs,vec_cast)
-importFrom(vctrs,vec_cbind)
 importFrom(vctrs,vec_data)
 importFrom(vctrs,vec_duplicate_any)
 importFrom(vctrs,vec_equal)

R/epiprocess-package.R

@@ -29,7 +29,6 @@
 #' @importFrom rlang is_bare_integerish
 #' @importFrom tools toTitleCase
 #' @importFrom vctrs vec_cast
-#' @importFrom vctrs vec_cbind
 #' @importFrom vctrs vec_data
 #' @importFrom vctrs vec_equal
 #' @importFrom vctrs vec_in

R/slide.R

@@ -342,18 +342,18 @@ epi_slide_one_group <- function(
   all_dates <- .date_seq_list$all_dates
   missing_times <- all_dates[!vec_in(all_dates, .data_group$time_value)]
   .data_group <- reclass(vec_rbind(
-    .data_group, # (epi_df; epi_slide uses .keep = TRUE)
-    vec_cbind( # (tibble -> vec_rbind produces tibble)
-      .group_key,
-      new_tibble(vec_recycle_common(
-        time_value = c(
-          missing_times,
-          .date_seq_list$pad_early_dates,
-          .date_seq_list$pad_late_dates
-        ),
-        .real = FALSE
-      ))
-    )
+    .data_group,
+    # (^ epi_df; epi_slide uses .keep = TRUE)
+    # (v tibble -> vec_rbind outputs tibble)
+    new_tibble(vec_recycle_common(
+      !!!.group_key,
+      time_value = c(
+        missing_times,
+        .date_seq_list$pad_early_dates,
+        .date_seq_list$pad_late_dates
+      ),
+      .real = FALSE
+    ))
     # we should be adding time values of the same time_type (and shouldn't be
     # introducing duplicate epikeytime values); we can reclass without checks:
   ), attr(.data_group, "metadata")) %>%