Merge pull request #396 from cmu-delphi/main

sync main -> dev

Author: dshemetov

tests/testthat/_snaps/dist_quantiles.md

@@ -1,7 +1,7 @@
 # constructor returns reasonable quantiles
 
     Code
-      new_quantiles(rnorm(5), rnorm(5))
+      new_quantiles(rnorm(5), c(-2, -1, 0, 1, 2))
     Condition
       Error in `new_quantiles()`:
       ! `quantile_levels` must lie in [0, 1].

tests/testthat/_snaps/layer_predict.md

@@ -1,7 +1,7 @@
 library(distributional)
 
 test_that("constructor returns reasonable quantiles", {
-  expect_snapshot(error = TRUE, new_quantiles(rnorm(5), rnorm(5)))
+  expect_snapshot(error = TRUE, new_quantiles(rnorm(5), c(-2, -1, 0, 1, 2)))
   expect_silent(new_quantiles(sort(rnorm(5)), sort(runif(5))))
   expect_snapshot(error = TRUE, new_quantiles(sort(rnorm(5)), sort(runif(2))))
   expect_silent(new_quantiles(1:5, 1:5 / 10))

tests/testthat/test-dist_quantiles.R

@@ -48,7 +48,7 @@ test_that("layer_predict dots validation", {
   # We don't detect completely-bogus arg names until predict time:
   expect_no_error(f_bad_arg <- frosting() %>% layer_predict(bogus_argument = "something"))
   wf_bad_arg <- wf %>% add_frosting(f_bad_arg)
-  expect_snapshot(error = TRUE, predict(wf_bad_arg, latest))
+  expect_error(predict(wf_bad_arg, latest))
   # ^ (currently with a awful error message, due to an extra comma in parsnip::check_pred_type_dots)
 
   # Some argument names only apply for some prediction `type`s; we don't check