Nans: update to the finalized nancode names

Author: dshemetov

integrations/acquisition/covidcast/test_csv_uploading.py

@@ -82,7 +82,7 @@ def test_uploading(self):
     # invalid, missing with an inf value
     with open(source_receiving_dir + '/20200419_state_test_missing1.csv', 'w') as f:
       f.write('geo_id,val,se,sample_size,missing_val,missing_se,missing_sample_size\n')
-      f.write(f'fl,inf,0.3,30,{Nans.UNKNOWN},{Nans.NOT_MISSING},{Nans.NOT_MISSING}\n')
+      f.write(f'fl,inf,0.3,30,{Nans.OTHER},{Nans.NOT_MISSING},{Nans.NOT_MISSING}\n')
 
     # invalid, missing with an incorrect missing code
     with open(source_receiving_dir + '/20200419_state_test_missing2.csv', 'w') as f:
@@ -92,7 +92,7 @@ def test_uploading(self):
     # invalid, no missing with an incorrect missing code
     with open(source_receiving_dir + '/20200419_state_test_missing3.csv', 'w') as f:
       f.write('geo_id,val,se,sample_size,missing_val,missing_se,missing_sample_size\n')
-      f.write(f'wa,3,0.3,30,{Nans.UNKNOWN},{Nans.NOT_MISSING},{Nans.NOT_MISSING}\n')
+      f.write(f'wa,3,0.3,30,{Nans.OTHER},{Nans.NOT_MISSING},{Nans.NOT_MISSING}\n')
 
     # valid wip
     with open(source_receiving_dir + '/20200419_state_wip_prototype.csv', 'w') as f:
@@ -221,7 +221,7 @@ def apply_lag(expected_epidata):
           'sample_size': 20,
           'direction': None,
           'signal': 'test_no_missing',
-          'missing_value': Nans.UNKNOWN,
+          'missing_value': Nans.OTHER,
           'missing_stderr': Nans.NOT_MISSING,
           'missing_sample_size': Nans.NOT_MISSING,
         },

integrations/server/test_covidcast.py

@@ -622,7 +622,7 @@ def test_nullable_columns(self):
       insert into covidcast values
         (0, 'src', 'sig', 'day', 'county', 20200414, '01234',
           123, 0.123, NULL, NULL, 456, NULL, 20200414, 0, 1, False,
-          {Nans.NOT_MISSING}, {Nans.UNKNOWN}, {Nans.UNKNOWN})
+          {Nans.NOT_MISSING}, {Nans.OTHER}, {Nans.OTHER})
     ''')
     self.cnx.commit()
 
@@ -651,8 +651,8 @@ def test_nullable_columns(self):
         'lag': 0,
         'signal': 'sig',
         'missing_value': Nans.NOT_MISSING,
-        'missing_stderr': Nans.UNKNOWN,
-        'missing_sample_size': Nans.UNKNOWN
+        'missing_stderr': Nans.OTHER,
+        'missing_sample_size': Nans.OTHER
        }],
       'message': 'success',
     }

src/acquisition/covidcast/csv_importer.py

@@ -238,7 +238,7 @@ def validate_missing_code(row, attr_quantity, attr_name):
       return missing_entry
     else:
       if attr_quantity is None:
-        return Nans.UNKNOWN.value
+        return Nans.OTHER.value
       return Nans.NOT_MISSING.value
 
   @staticmethod

tests/acquisition/covidcast/test_csv_importer.py

@@ -171,9 +171,9 @@ def make_row(
       (make_row(missing_val='missing_val'), 'missing_val'),
       (make_row(missing_se='missing_val'), 'missing_se'),
       (make_row(missing_sample_size='missing_val'), 'missing_sample_size'),
-      (make_row(val='1.2', missing_val=Nans.UNKNOWN), 'missing_val'),
-      (make_row(se='1.2', missing_se=Nans.UNKNOWN), 'missing_se'),
-      (make_row(sample_size='1.2', missing_sample_size=Nans.UNKNOWN), 'missing_sample_size')
+      (make_row(val='1.2', missing_val=Nans.OTHER), 'missing_val'),
+      (make_row(se='1.2', missing_se=Nans.OTHER), 'missing_se'),
+      (make_row(sample_size='1.2', missing_sample_size=Nans.OTHER), 'missing_sample_size')
     ]
 
     for ((geo_type, row), field) in failure_cases:
@@ -195,7 +195,7 @@ def make_row(
     # a nominal case with missing values
     geo_type, row = make_row(
       se='', sample_size='NA',
-      missing_se=Nans.UNKNOWN, missing_sample_size=Nans.UNKNOWN
+      missing_se=Nans.OTHER, missing_sample_size=Nans.OTHER
     )
     values, error = CsvImporter.extract_and_check_row(row, geo_type)