Merge pull request #1028 from cmu-delphi/leonlu2/test_signal_wildcard

Leonlu2/test signal wildcard

Author: krivard

integrations/server/test_covidcast.py

@@ -63,6 +63,18 @@ def _insert_placeholder_set_three(self):
     self._insert_rows(rows)
     return rows
 
+  def _insert_placeholder_set_four(self):
+    rows = [
+      self._make_placeholder_row(source='src1', signal=str(i)*5, value=i*1., stderr=i*10., sample_size=i*100.)[0]
+      for i in [1, 2, 3]
+    ] + [
+      # signal intended to overlap with the signal above
+      self._make_placeholder_row(source='src2', signal=str(i-3)*5, value=i*1., stderr=i*10., sample_size=i*100.)[0]
+      for i in [4, 5, 6]
+    ]
+    self._insert_rows(rows)
+    return rows 
+
   def test_round_trip(self):
     """Make a simple round-trip with some sample data."""
 
@@ -225,6 +237,26 @@ def test_location_wildcard(self):
       'message': 'success',
     })
 
+  def test_signal_wildcard(self):
+    """Select all signals with a wildcard query."""
+
+    # insert placeholder data
+    rows = self._insert_placeholder_set_four()
+    expected_signals = [
+      self.expected_from_row(r) for r in rows[:3]
+    ]
+
+    # make the request
+    response, _ = self.request_based_on_row(rows[0], signals="*")
+
+    self.maxDiff = None
+    # assert that the right data came back
+    self.assertEqual(response, {
+      'result': 1,
+      'epidata': expected_signals,
+      'message': 'success',
+    })
+
   def test_geo_value(self):
     """test different variants of geo types: single, *, multi."""
 

src/server/endpoints/covidcast.py

@@ -49,8 +49,10 @@ def parse_source_signal_pairs() -> List[SourceSignalPair]:
     ds = request.values.get("data_source")
     if ds:
         # old version
-        require_any("signal", "signals")
+        require_any("signal", "signals", empty=True)
         signals = extract_strings(("signals", "signal"))
+        if len(signals) == 1 and signals[0] == "*":
+            return [SourceSignalPair(ds, True)]
         return [SourceSignalPair(ds, signals)]
 
     if ":" not in request.values.get("signal", ""):