Skip to content

Commit 7d2bf5e

Browse files
drop the get_earliest_issue_from_metadata
1 parent 14999a3 commit 7d2bf5e

File tree

2 files changed

+0
-22
lines changed

2 files changed

+0
-22
lines changed

src/acquisition/covidcast/signal_dash_data_generator.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -184,13 +184,6 @@ def get_latest_issue_from_metadata(dashboard_signal, metadata):
184184
max_issue = df_for_source["max_issue"].max()
185185
return pd.to_datetime(str(max_issue), format="%Y%m%d").date()
186186

187-
def get_earliest_issue_from_metadata(dashboard_signal, metadata):
188-
"""Get the least recent issue date for the signal."""
189-
df_for_source = metadata[(metadata.data_source == dashboard_signal.source) & (
190-
metadata.signal == dashboard_signal.covidcast_signal)]
191-
min_issue = df_for_source["min_issue"].min()
192-
return pd.to_datetime(str(min_issue), format="%Y%m%d").date()
193-
194187

195188
def get_latest_time_value_from_metadata(dashboard_signal, metadata):
196189
"""Get the most recent date with data for the signal."""

tests/acquisition/covidcast/test_signal_dash_data_generator.py

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
DashboardSignalCoverage,
2121
DashboardSignal,
2222
get_latest_issue_from_metadata,
23-
get_earliest_issue_from_metadata,
2423
get_latest_time_value_from_metadata,
2524
get_coverage
2625
)
@@ -168,20 +167,6 @@ def test_get_latest_issue_from_metadata(self):
168167
issue_date = get_latest_issue_from_metadata(signal, metadata)
169168
self.assertEqual(issue_date, date(2021, 1, 1))
170169

171-
def test_get_earliest_issue_from_metadata(self):
172-
signal = DashboardSignal(
173-
db_id=1, name="Change", source="chng",
174-
covidcast_signal="chng-sig",
175-
latest_coverage_update=date(2020, 1, 1),
176-
latest_status_update=date(2020, 1, 1))
177-
data = [['chng', 'chng-sig', 20200101],
178-
['chng', 'chng-sig', 20210101],
179-
['quidel', 'quidel-sig', 20220101]]
180-
metadata = pd.DataFrame(data, columns=['data_source', 'signal', 'min_issue'])
181-
182-
issue_date = get_earliest_issue_from_metadata(signal, metadata)
183-
self.assertEqual(issue_date, date(2020, 1, 1))
184-
185170
def test_get_latest_time_value_from_metadata(self):
186171
signal = DashboardSignal(
187172
db_id=1, name="Change", source="chng",

0 commit comments

Comments
 (0)