Skip to content

Commit 59d3734

Browse files
committed
generalize coalesce for start/end dates
1 parent e71211b commit 59d3734

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

scripts/signal_spreadsheet_updater.R

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,15 +181,10 @@ source3 <- left_join(
181181
by = c("Signal" = "signal", "data_source")
182182
)
183183

184-
# Fill in Temporal Scope Start/End for quidel signals by coalescing the existing
185-
# column with the new data; quidel dates have already been filled in manually in
186-
# the spreadsheet.
187-
source3$min_time <- case_when(
188-
source3$data_source == "quidel" ~ coalesce(source3$min_time, source3$`Temporal Scope Start`)
189-
)
190-
source3$max_time <- case_when(
191-
source3$data_source == "quidel" ~ coalesce(source3$max_time, source3$`Temporal Scope Start`)
192-
)
184+
# Assume new values for Temporal Scope Start/End are correct, but use previous
185+
# (manual) values as backup.
186+
source3$min_time <- coalesce(source3$min_time, source3$`Temporal Scope Start`)
187+
source3$max_time <- coalesce(source3$max_time, source3$`Temporal Scope End`)
193188

194189
# Select relevant columns
195190
# first reformat max_time col to character for compatibility
@@ -566,7 +561,7 @@ source_updated <- left_join(
566561
source_updated, leftover_signal_geos_manual,
567562
by = c("Signal" = "signal", "data_source")
568563
) %>%
569-
mutate(`Delphi-Aggregated Geography` = coalesce(geos_list, `Delphi-Aggregated Geography`)) %>%
564+
mutate(`Delphi-Aggregated Geography` = geos_list) %>%
570565
select(-geos_list)
571566

572567

0 commit comments

Comments
 (0)