Apply suggestions from code review

Co-authored-by: Katie Mazaitis <[email protected]>
Co-authored-by: melange396 <[email protected]>

Author: 3 people

integrations/server/test_covidcast_endpoints.py

@@ -40,6 +40,7 @@ def _fetch(self, endpoint="/", is_compatibility=False, **params):
         if is_compatibility:
             url = BASE_URL_OLD
             # only set endpoint if it's not already set
+            # only set endpoint if it's not already set
             params.setdefault("endpoint", "covidcast")
             if params.get("source"):
                 params.setdefault("data_source", params.get("source"))
@@ -77,7 +78,7 @@ def test_basic(self):
 
     def test_compatibility(self):
         """Request at the /api.php endpoint."""
-        rows = [CovidcastRow.make_default_row(source="src", signal="sig", time_value=20200401 + i, value=i) for i in range(10)]
+        rows = [CovidcastRow.make_default_row(source="src", signal="sig", time_value=2020_04_01 + i, value=i) for i in range(10)]
         first = rows[0]
         self._insert_rows(rows)
 
@@ -93,7 +94,7 @@ def test_trend(self):
         """Request a signal from the /trend endpoint."""
 
         num_rows = 30
-        rows = [CovidcastRow.make_default_row(time_value=20200401 + i, value=i) for i in range(num_rows)]
+        rows = [CovidcastRow.make_default_row(time_value=2020_04_01 + i, value=i) for i in range(num_rows)]
         first = rows[0]
         last = rows[-1]
         ref = rows[num_rows // 2]
@@ -129,7 +130,7 @@ def test_trendseries(self):
         """Request a signal from the /trendseries endpoint."""
 
         num_rows = 3
-        rows = [CovidcastRow.make_default_row(time_value=20200401 + i, value=num_rows - i) for i in range(num_rows)]
+        rows = [CovidcastRow.make_default_row(time_value=2020_04_01 + i, value=num_rows - i) for i in range(num_rows)]
         first = rows[0]
         last = rows[-1]
         self._insert_rows(rows)
@@ -221,7 +222,7 @@ def test_correlation(self):
     def test_csv(self):
         """Request a signal from the /csv endpoint."""
 
-        rows = [CovidcastRow.make_default_row(time_value=20200401 + i, value=i) for i in range(10)]
+        rows = [CovidcastRow.make_default_row(time_value=2020_04_01 + i, value=i) for i in range(10)]
         first = rows[0]
         self._insert_rows(rows)
 
@@ -262,7 +263,7 @@ def test_meta(self):
         """Request a signal from the /meta endpoint."""
 
         num_rows = 10
-        rows = [CovidcastRow.make_default_row(time_value=20200401 + i, value=i, source="fb-survey", signal="smoothed_cli") for i in range(num_rows)]
+        rows = [CovidcastRow.make_default_row(time_value=2020_04_01 + i, value=i, source="fb-survey", signal="smoothed_cli") for i in range(num_rows)]
         self._insert_rows(rows)
         first = rows[0]
         last = rows[-1]
@@ -302,7 +303,7 @@ def test_coverage(self):
         """Request a signal from the /coverage endpoint."""
 
         num_geos_per_date = [10, 20, 30, 40, 44]
-        dates = [20200401 + i for i in range(len(num_geos_per_date))]
+        dates = [2020_04_01 + i for i in range(len(num_geos_per_date))]
         rows = [CovidcastRow.make_default_row(time_value=dates[i], value=i, geo_value=str(geo_value)) for i, num_geo in enumerate(num_geos_per_date) for geo_value in range(num_geo)]
         self._insert_rows(rows)
         first = rows[0]