Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonblocking sending, multi-processing and multi-threading support #48

Open
kusha opened this issue Aug 3, 2018 · 2 comments
Open

Nonblocking sending, multi-processing and multi-threading support #48

kusha opened this issue Aug 3, 2018 · 2 comments

Comments

@kusha
Copy link
Contributor

kusha commented Aug 3, 2018

Hi,

I'm using your logger in my application. I've made some changes (modified inherited CMRESHandler class):

  • the application logs a lot of messages, so I've implemented non-blocking logging (via multiprocessing queue and bulk_send in a separate process);
  • it is a multiprocessing application, where some processes have multiple threads, so there are additional changes.

I can prepare a pull request, and leave it as another class (not everyone needs those features). Are you interested in?

@ajhodges
Copy link

As a user, I am very interested in your fork.

@cmanaha
Copy link
Owner

cmanaha commented Sep 24, 2018

Have you added to it testing cases and coverage to it ? Was there any reason in particular to deviate so much from the original implementation ? I guess that just reading the code and checking with the tests you have should give all the evidence on why to change the implementation.

As for merging. I'd suggest keeping it simple. If your tests/coverage and the implementation show's thats a better approach, I'd rather prefer to consolidate into one solution (your solution) that works well in both cases. There is no need for duplication or extra complexity...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants