Skip to content

Commit 69de729

Browse files
josephperrottthePunderWoman
authored andcommitted
build: migrate angular-in-memory-web-api to use rules_js (angular#61524)
Use ts_project and ng_project for building angular-in-memory-web-api PR Close angular#61524
1 parent 83d004f commit 69de729

File tree

3 files changed

+23
-17
lines changed

3 files changed

+23
-17
lines changed

packages/misc/angular-in-memory-web-api/BUILD.bazel

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,22 +1,24 @@
1-
load("//tools:defaults.bzl", "ng_module", "ng_package")
1+
load("//tools:defaults.bzl", "ng_package")
2+
load("//tools:defaults2.bzl", "ng_project")
23

34
package(default_visibility = ["//visibility:public"])
45

5-
ng_module(
6+
ng_project(
67
name = "angular-in-memory-web-api",
7-
package_name = "angular-in-memory-web-api",
88
srcs = glob(
99
[
1010
"*.ts",
1111
"src/**/*.ts",
1212
],
1313
),
14-
module_name = "angular-in-memory-web-api",
15-
deps = [
14+
interop_deps = [
1615
"//packages/common",
1716
"//packages/common/http",
18-
"//packages/core",
19-
"@npm//rxjs",
17+
],
18+
module_name = "angular-in-memory-web-api",
19+
deps = [
20+
"//:node_modules/rxjs",
21+
"//packages/core:core_rjs",
2022
],
2123
)
2224

packages/misc/angular-in-memory-web-api/test/BUILD.bazel

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,23 @@
1-
load("//tools:defaults.bzl", "karma_web_test_suite", "ts_library")
1+
load("//tools:defaults.bzl", "karma_web_test_suite")
2+
load("//tools:defaults2.bzl", "ts_project")
23

3-
ts_library(
4+
ts_project(
45
name = "test_lib",
56
testonly = True,
67
srcs = glob(["**/*.ts"]),
8+
interop_deps = [
9+
"//packages/common",
10+
"//packages/common/http",
11+
],
712
# Visible to //:saucelabs_unit_tests_poc target
813
visibility = ["//:__pkg__"],
914
deps = [
10-
"//packages/common",
11-
"//packages/common/http",
12-
"//packages/core",
13-
"//packages/core/testing",
14-
"//packages/misc/angular-in-memory-web-api",
15-
"@npm//@types/jasmine-ajax",
16-
"@npm//jasmine-ajax",
17-
"@npm//rxjs",
15+
"//:node_modules/@types/jasmine-ajax",
16+
"//:node_modules/jasmine-ajax",
17+
"//:node_modules/rxjs",
18+
"//packages/core:core_rjs",
19+
"//packages/core/testing:testing_rjs",
20+
"//packages/misc/angular-in-memory-web-api:angular-in-memory-web-api_rjs",
1821
],
1922
)
2023

packages/tsconfig-build.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131
"inlineSources": true,
3232
"importHelpers": true,
3333
"paths": {
34+
"angular-in-memory-web-api": ["./misc/angular-in-memory-web-api/index"],
3435
"zone.js": ["./zone.js/lib/zone"],
3536
"@angular/*": ["./*/index"],
3637
"@angular/common/locales/*": ["./common/locales/*"]

0 commit comments

Comments
 (0)