Skip to content

Commit 6721512

Browse files
committed
refactor(platform-browser): further reduce runtime code size of shared style host
The `SharedStylesHost` class has been refactored to further reduce the runtime code size. SSR generated component styles are now added directly into the usage records to avoid the need for additional data structures and lookups when adding a component style. The code reduction in a prerelease newly generated Angular CLI application for production is ~190 bytes. Before: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-3X2VHGTM.js | main | 208.26 kB | 56.30 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.78 kB | 67.58 kB ``` After: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-MGOZ6Q4F.js | main | 208.07 kB | 56.26 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.59 kB | 67.54 kB ```
1 parent 9dbe6fc commit 6721512

11 files changed

Lines changed: 89 additions & 71 deletions

File tree

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -827,6 +827,9 @@
827827
{
828828
"name": "createNotification"
829829
},
830+
{
831+
"name": "createStyleElement"
832+
},
830833
{
831834
"name": "createTView"
832835
},
@@ -1356,10 +1359,10 @@
13561359
"name": "remove"
13571360
},
13581361
{
1359-
"name": "removeAll"
1362+
"name": "removeClass"
13601363
},
13611364
{
1362-
"name": "removeClass"
1365+
"name": "removeElements"
13631366
},
13641367
{
13651368
"name": "removeFromArray"

packages/core/test/bundling/animations/bundle.golden_symbols.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -890,6 +890,9 @@
890890
{
891891
"name": "createPlatformFactory"
892892
},
893+
{
894+
"name": "createStyleElement"
895+
},
893896
{
894897
"name": "createTView"
895898
},
@@ -1431,10 +1434,10 @@
14311434
"name": "remove"
14321435
},
14331436
{
1434-
"name": "removeAll"
1437+
"name": "removeClass"
14351438
},
14361439
{
1437-
"name": "removeClass"
1440+
"name": "removeElements"
14381441
},
14391442
{
14401443
"name": "removeFromArray"

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,9 @@
683683
{
684684
"name": "createPlatformFactory"
685685
},
686+
{
687+
"name": "createStyleElement"
688+
},
686689
{
687690
"name": "createTView"
688691
},
@@ -1158,7 +1161,7 @@
11581161
"name": "remove"
11591162
},
11601163
{
1161-
"name": "removeAll"
1164+
"name": "removeElements"
11621165
},
11631166
{
11641167
"name": "removeFromArray"

packages/core/test/bundling/defer/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -761,6 +761,9 @@
761761
{
762762
"name": "createNotification"
763763
},
764+
{
765+
"name": "createStyleElement"
766+
},
764767
{
765768
"name": "createTView"
766769
},
@@ -2406,7 +2409,7 @@
24062409
"name": "remove"
24072410
},
24082411
{
2409-
"name": "removeAll"
2412+
"name": "removeElements"
24102413
},
24112414
{
24122415
"name": "removeFromArray"

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -980,6 +980,9 @@
980980
{
981981
"name": "createPlatformFactory"
982982
},
983+
{
984+
"name": "createStyleElement"
985+
},
983986
{
984987
"name": "createTView"
985988
},
@@ -1725,7 +1728,7 @@
17251728
"name": "remove"
17261729
},
17271730
{
1728-
"name": "removeAll"
1731+
"name": "removeElements"
17291732
},
17301733
{
17311734
"name": "removeFromArray"

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -944,6 +944,9 @@
944944
{
945945
"name": "createPlatformFactory"
946946
},
947+
{
948+
"name": "createStyleElement"
949+
},
947950
{
948951
"name": "createTView"
949952
},
@@ -1692,7 +1695,7 @@
16921695
"name": "remove"
16931696
},
16941697
{
1695-
"name": "removeAll"
1698+
"name": "removeElements"
16961699
},
16971700
{
16981701
"name": "removeFromArray"

packages/core/test/bundling/hydration/bundle.golden_symbols.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -746,6 +746,9 @@
746746
{
747747
"name": "createOperatorSubscriber"
748748
},
749+
{
750+
"name": "createStyleElement"
751+
},
749752
{
750753
"name": "createTView"
751754
},
@@ -1268,15 +1271,15 @@
12681271
{
12691272
"name": "remove"
12701273
},
1271-
{
1272-
"name": "removeAll"
1273-
},
12741274
{
12751275
"name": "removeDehydratedView"
12761276
},
12771277
{
12781278
"name": "removeDehydratedViews"
12791279
},
1280+
{
1281+
"name": "removeElements"
1282+
},
12801283
{
12811284
"name": "removeFromArray"
12821285
},

packages/core/test/bundling/router/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1121,6 +1121,9 @@
11211121
{
11221122
"name": "createSegmentGroupFromRoute"
11231123
},
1124+
{
1125+
"name": "createStyleElement"
1126+
},
11241127
{
11251128
"name": "createTView"
11261129
},
@@ -1965,7 +1968,7 @@
19651968
"name": "remove"
19661969
},
19671970
{
1968-
"name": "removeAll"
1971+
"name": "removeElements"
19691972
},
19701973
{
19711974
"name": "removeFromArray"

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -614,6 +614,9 @@
614614
{
615615
"name": "createNotification"
616616
},
617+
{
618+
"name": "createStyleElement"
619+
},
617620
{
618621
"name": "createTView"
619622
},
@@ -1020,7 +1023,7 @@
10201023
"name": "remove"
10211024
},
10221025
{
1023-
"name": "removeAll"
1026+
"name": "removeElements"
10241027
},
10251028
{
10261029
"name": "removeFromArray"

packages/core/test/bundling/todo/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -800,6 +800,9 @@
800800
{
801801
"name": "createPlatformFactory"
802802
},
803+
{
804+
"name": "createStyleElement"
805+
},
803806
{
804807
"name": "createTView"
805808
},
@@ -1374,7 +1377,7 @@
13741377
"name": "remove"
13751378
},
13761379
{
1377-
"name": "removeAll"
1380+
"name": "removeElements"
13781381
},
13791382
{
13801383
"name": "removeFromArray"

0 commit comments

Comments
 (0)