Skip to content

Commit 0163eb2

Browse files
committed
refactor(platform-browser): reduce runtime code size of shared style host
The `SharedStylesHost` class has been refactored to both reduce the runtime code size and also modernize some of the code structures. The class is also adjusted to better support reuse via subclassing or other reuses in the future. Additional comments have been added to improve readability as well. The code reduction in a prerelease newly generated Angular CLI application for production is ~410 bytes. Before: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-GOQKBZBZ.js | main | 208.67 kB | 56.41 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 243.19 kB | 67.69 kB ``` After: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-CRTDDKPH.js | main | 208.26 kB | 56.32 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.78 kB | 67.61 kB ```
1 parent cd24eaf commit 0163eb2

File tree

11 files changed

+177
-116
lines changed

11 files changed

+177
-116
lines changed

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1355,6 +1355,9 @@
13551355
{
13561356
"name": "remove"
13571357
},
1358+
{
1359+
"name": "removeAll"
1360+
},
13581361
{
13591362
"name": "removeClass"
13601363
},

packages/core/test/bundling/animations/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1430,6 +1430,9 @@
14301430
{
14311431
"name": "remove"
14321432
},
1433+
{
1434+
"name": "removeAll"
1435+
},
14331436
{
14341437
"name": "removeClass"
14351438
},

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1157,6 +1157,9 @@
11571157
{
11581158
"name": "remove"
11591159
},
1160+
{
1161+
"name": "removeAll"
1162+
},
11601163
{
11611164
"name": "removeFromArray"
11621165
},

packages/core/test/bundling/defer/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2405,6 +2405,9 @@
24052405
{
24062406
"name": "remove"
24072407
},
2408+
{
2409+
"name": "removeAll"
2410+
},
24082411
{
24092412
"name": "removeFromArray"
24102413
},

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1724,6 +1724,9 @@
17241724
{
17251725
"name": "remove"
17261726
},
1727+
{
1728+
"name": "removeAll"
1729+
},
17271730
{
17281731
"name": "removeFromArray"
17291732
},

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1691,6 +1691,9 @@
16911691
{
16921692
"name": "remove"
16931693
},
1694+
{
1695+
"name": "removeAll"
1696+
},
16941697
{
16951698
"name": "removeFromArray"
16961699
},

packages/core/test/bundling/hydration/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1268,6 +1268,9 @@
12681268
{
12691269
"name": "remove"
12701270
},
1271+
{
1272+
"name": "removeAll"
1273+
},
12711274
{
12721275
"name": "removeDehydratedView"
12731276
},

packages/core/test/bundling/router/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1964,6 +1964,9 @@
19641964
{
19651965
"name": "remove"
19661966
},
1967+
{
1968+
"name": "removeAll"
1969+
},
19671970
{
19681971
"name": "removeFromArray"
19691972
},

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,6 +1019,9 @@
10191019
{
10201020
"name": "remove"
10211021
},
1022+
{
1023+
"name": "removeAll"
1024+
},
10221025
{
10231026
"name": "removeFromArray"
10241027
},

packages/core/test/bundling/todo/bundle.golden_symbols.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1373,6 +1373,9 @@
13731373
{
13741374
"name": "remove"
13751375
},
1376+
{
1377+
"name": "removeAll"
1378+
},
13761379
{
13771380
"name": "removeFromArray"
13781381
},

0 commit comments

Comments
 (0)