Remove circular reference from stream reader

Author: valga

src/ProxyConnector.php

@@ -134,14 +134,11 @@ public function connect($uri)
 
             // keep buffering data until headers are complete
             $buffer = '';
-            $fn = function ($chunk) use (&$buffer, &$fn, $deferred, $stream) {
+            $fn = function ($chunk) use (&$buffer, $deferred, $stream) {
                 $buffer .= $chunk;
 
                 $pos = strpos($buffer, "\r\n\r\n");
                 if ($pos !== false) {
-                    // end of headers received => stop buffering
-                    $stream->removeListener('data', $fn);
-
                     // try to parse headers as response message
                     try {
                         $response = Psr7\parse_response(substr($buffer, 0, $pos));
@@ -191,7 +188,10 @@ public function connect($uri)
 
             $stream->write("CONNECT " . $host . ":" . $port . " HTTP/1.1\r\nHost: " . $host . ":" . $port . "\r\n" . $auth . "\r\n");
 
-            return $deferred->promise();
+            return $deferred->promise()->always(function () use ($stream, $fn) {
+                // Stop buffering when connection has been established or rejected.
+                $stream->removeListener('data', $fn);
+            });
         }, function (Exception $e) use ($proxyUri) {
             throw new RuntimeException('Unable to connect to proxy (ECONNREFUSED)', defined('SOCKET_ECONNREFUSED') ? SOCKET_ECONNREFUSED : 111, $e);
         });