Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deny warnings in check features #963

Open
mayconamaroCW opened this issue May 31, 2024 · 1 comment
Open

deny warnings in check features #963

mayconamaroCW opened this issue May 31, 2024 · 1 comment
Assignees
Labels
workflows Tasks about Github Actions

Comments

@mayconamaroCW
Copy link
Contributor

prevent PR to be merged with warnings in any feature

@mayconamaroCW mayconamaroCW added the workflows Tasks about Github Actions label May 31, 2024
@mayconamaroCW mayconamaroCW self-assigned this May 31, 2024
@mayconamaroCW
Copy link
Contributor Author

cargo hack has no --deny-warnings feature (because cargo check does not have it as well)

RUSTFLAGS="-D warnings" apply to dependencies, and conflicts with rust-analyzer

Next approach to try: craft a manual script that uses cargo clippy instead of cargo hack with check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflows Tasks about Github Actions
Projects
None yet
Development

No branches or pull requests

1 participant