Repository navigation
chore: Control group color adjustments - #5163
Merged
Merged
Conversation
jperals
had a problem deploying
to
dev-pages-react16
October 20, 2026 13:48 — with 
GitHub Actions
Error
GitHub Actions
Error
jperals
had a problem deploying
to
dev-pages-react18
October 20, 2026 13:48 — with
GitHub Actions
Error
GitHub Actions
Error
jperals
force-pushed
the
dev-v3-jotresse-control-group-border-color
branch
from
October 20, 2026 13:49
2c959b3 to
26cdb5c
Compare
jperals
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5163 +/- ##
=======================================
Coverage 97.73% 97.74%
=======================================
Files 996 996
Lines 32152 32182 +30
Branches 11860 11877 +17
=======================================
+ Hits 31424 31455 +31
+ Misses 683 682 -1
Partials 45 45 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
/override-visual-regression Same as here |
georgylobko
previously approved these changes
Oct 21, 2026
georgylobko
left a comment
georgylobko
left a comment
Member
There was a problem hiding this comment.
[nit] There’s no space between the header and the control group on the example page. Could be a follow-up.
Member
Author
Right, addressed now so that we don't need to override visual regression results later |
jperals
enabled auto-merge
October 21, 2026 11:02
georgylobko
approved these changes
Oct 21, 2026
georgylobko
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
How has this been tested?
Added dev page for visual regression. Test definitions will be provided separately before release. The presence or absence of the action button's background becomes apparent in OneTheme dark mode, where the background of Container and Item card is different than the App Layout's main content slot.
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.