Await services more strictly in tests

There was a race that would sometimes return a service, before it had
received its load balancer addresses, causing some tests to fail
rarely and randomly.

Author: href

pkg/internal/integration/service_test.go

@@ -255,7 +255,15 @@ func (s *IntegrationTestSuite) AwaitServiceReady(
 
 		if service.Annotations != nil {
 			uuid := service.Annotations["k8s.cloudscale.ch/loadbalancer-uuid"]
-			if uuid != "" {
+
+			// EnsureLoadBalancer sets the annotation, and then returns the
+			// load balancer status to Kubernetes. This means there is a short
+			// window between setting the annotation, and the service receving
+			// its load balancer configuration.
+			//
+			// To avoid races, we therefore have to check for the annotation,
+			// as well as the load balancer state.
+			if uuid != "" && len(service.Status.LoadBalancer.Ingress) > 0 {
 				return service
 			}
 		}