address PR feedback

Author: neowulf

.gitmodules

@@ -1,4 +1,4 @@
 [submodule "src/code.cloudfoundry.org/routing-api"]
 	path = src/code.cloudfoundry.org/routing-api
-	url = https://github.com/neowulf/routing-api
-	branch = siva/sni_routing-pr
+	url = https://github.com/cloudfoundry/routing-api
+	branch = main

jobs/tcp_router/spec

@@ -59,10 +59,6 @@ properties:
       be set. For mTLS also set tcp_router.backend_tls.client_cert and
       tcp_router.backend_tls.client_key.
     default: false
-  tcp_router.frontend_tls_pem.enabled:
-    description: |
-      This is enabled if certificates and keys are provided for tls traffic to be terminated at tcp router.
-    default: false
   tcp_router.frontend_tls_pem.certificate_path:
     description: Path to the certs and key store
   tcp_router.frontend_tls:
@@ -84,6 +80,7 @@ properties:
     description: "TCP Router's TLS client private key used for mTLS with route backends"
   tcp_router.backend_tls.ca_cert:
     description: "TCP Router's TLS CA used with route backends"
+
   routing_api.uri:
     description: "URL where the routing API can be reached internally"
     default: https://routing-api.service.cf.internal

scripts/create-docker-container.bash

@@ -1,9 +1,9 @@
 #!/bin/bash
 
-set -e
+set -eu
 set -o pipefail
 
-THIS_FILE_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" >/dev/null 2>&1 && pwd)"
+THIS_FILE_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" >/dev/null 2>&1 && pwd )"
 CI="${THIS_FILE_DIR}/../../wg-app-platform-runtime-ci"
 . "$CI/shared/helpers/git-helpers.bash"
 REPO_NAME=$(git_get_remote_name)
@@ -47,3 +47,4 @@ docker run -it \
   ${ARGS} \
   "${IMAGE}" \
   /bin/bash
+