Fix: wrong key used to access log-cache root endpoint. Fix cloudfoundry#1251 #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -24,6 +24,7 @@ | |||
| import org.cloudfoundry.logcache.v1.ReadRequest; | |||
| import org.cloudfoundry.logcache.v1.ReadResponse; | |||
| import org.cloudfoundry.reactor.ConnectionContext; | |||
| import org.cloudfoundry.reactor.RootProvider; | |||
There was a problem hiding this comment.
unused import, please remove
|
please rebase on main |
Lokowandtg
force-pushed
the
fixLogCacheRootAccess
branch
from
e35de47 to
b2435fa
Compare
Lokowandtg
force-pushed
the
fixLogCacheRootAccess
branch
from
b2435fa to
6ec4124
Compare
Kehrlann
requested changes
May 28, 2025
| import reactor.test.StepVerifier; | ||
|
|
||
| class ReactorLogCacheClientTest extends AbstractLogCacheApiTest { | ||
| private static final String API_ROOT = "http://api.my.rapid.server.com"; | ||
| private static final String LOGCACHE = "http://log-cache.my.rlog-cached.server.com"; |
There was a problem hiding this comment.
[question] is having api TWICE in the name intended, so that API.my.rAPId becomes LOG-CACHE.my.rLOG-CACHEd ?
It took me a minute to figure it out.
Comment on lines
+28
to
+30
| "log_cache": { | ||
| "href": "https://cache-for-logging.cf.lod-cfcli3.cfrt-sof.sapcloud.io" | ||
| }, |
There was a problem hiding this comment.
[suggestion] Be consistent with the other endpoints, and use the run.pivotal.io domain .
Kehrlann
reviewed
May 28, 2025
|
|
||
| private final ReactorLogCacheEndpoints logCacheEndpoints = | ||
| new ReactorLogCacheEndpoints( | ||
| CONNECTION_CONTEXT, this.root, TOKEN_PROVIDER, Collections.emptyMap()); | ||
|
|
||
| @Test | ||
| void getRootFromFallback() throws IOException { |
There was a problem hiding this comment.
[nitpick] You can drop the exception here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1251.
The key to access the log-cache URL hay a typo.
Add one testcase to the normal access with the key.
Add one testcase for the fallback if the root endpoint does not provide the value. This test shows that the letters "api" in the remaining URL are also replaced, leading to invalid results.